Fix software design suggestions

test/mobilizon_web/api/report_test.exs

@@ -7,6 +7,7 @@ defmodule MobilizonWeb.API.ReportTest do
   alias Mobilizon.Events.{Comment, Event}
   alias Mobilizon.Reports.{Note, Report}
   alias Mobilizon.Service.ActivityPub.Activity
+  alias Mobilizon.Service.Formatter
   alias Mobilizon.Users
   alias Mobilizon.Users.User
 
@@ -86,7 +87,7 @@ defmodule MobilizonWeb.API.ReportTest do
         _comment_2 = insert(:comment, actor: reported)
 
       comment = "This is really not acceptable, remote admin I don't know"
-      encoded_comment = Mobilizon.Service.Formatter.html_escape(comment, "text/plain")
+      encoded_comment = Formatter.html_escape(comment, "text/plain")
 
       assert {:ok, %Activity{} = flag_activity, _} =
                Reports.report(%{

test/mobilizon_web/controllers/nodeinfo_controller_test.exs

@@ -3,27 +3,20 @@ defmodule MobilizonWeb.NodeInfoControllerTest do
 
   alias Mobilizon.Config
 
+  alias MobilizonWeb.Endpoint
+  alias MobilizonWeb.Router.Helpers, as: Routes
+
   test "Get node info schemas", %{conn: conn} do
     conn = get(conn, node_info_path(conn, :schemas))
 
     assert json_response(conn, 200) == %{
              "links" => [
                %{
-                 "href" =>
-                   MobilizonWeb.Router.Helpers.node_info_url(
-                     MobilizonWeb.Endpoint,
-                     :nodeinfo,
-                     "2.0"
-                   ),
+                 "href" => Routes.node_info_url(Endpoint, :nodeinfo, "2.0"),
                  "rel" => "http://nodeinfo.diaspora.software/ns/schema/2.0"
                },
                %{
-                 "href" =>
-                   MobilizonWeb.Router.Helpers.node_info_url(
-                     MobilizonWeb.Endpoint,
-                     :nodeinfo,
-                     "2.1"
-                   ),
+                 "href" => Routes.node_info_url(Endpoint, :nodeinfo, "2.1"),
                  "rel" => "http://nodeinfo.diaspora.software/ns/schema/2.1"
                }
              ]

test/mobilizon_web/resolvers/admin_resolver_test.exs

@@ -9,6 +9,7 @@ defmodule MobilizonWeb.Resolvers.AdminResolverTest do
   alias Mobilizon.Users.User
 
   alias MobilizonWeb.AbsintheHelpers
+  alias MobilizonWeb.API
 
   describe "Resolver: List the action logs" do
     @note_content "This a note on a report"
@@ -20,12 +21,11 @@ defmodule MobilizonWeb.Resolvers.AdminResolverTest do
       %Actor{} = moderator_2 = insert(:actor, user: user_moderator_2)
 
       %Report{} = report = insert(:report)
-      MobilizonWeb.API.Reports.update_report_status(moderator, report, "resolved")
+      API.Reports.update_report_status(moderator, report, "resolved")
 
-      {:ok, %Note{} = note} =
-        MobilizonWeb.API.Reports.create_report_note(report, moderator_2, @note_content)
+      {:ok, %Note{} = note} = API.Reports.create_report_note(report, moderator_2, @note_content)
 
-      MobilizonWeb.API.Reports.delete_report_note(note, moderator_2)
+      API.Reports.delete_report_note(note, moderator_2)
 
       query = """
       {