Introduce follower, add tests

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/eventos/actors/actor.ex

@@ -1,36 +1,3 @@
-defmodule Eventos.Actors.Actor.TitleSlug do
-  @moduledoc """
-  Slug generation for groups
-  """
-  alias Eventos.Actors.Actor
-  import Ecto.Query
-  alias Eventos.Repo
-  use EctoAutoslugField.Slug, from: :title, to: :slug
-
-  def build_slug(sources, changeset) do
-    slug = super(sources, changeset)
-    build_unique_slug(slug, changeset)
-  end
-
-  defp build_unique_slug(slug, changeset) do
-    query =
-      from(
-        a in Actor,
-        where: a.slug == ^slug
-      )
-
-    case Repo.one(query) do
-      nil ->
-        slug
-
-      _story ->
-        slug
-        |> Eventos.Slug.increment_slug()
-        |> build_unique_slug(changeset)
-    end
-  end
-end
-
 import EctoEnum
 
 defenum(Eventos.Actors.ActorTypeEnum, :actor_type, [
@@ -131,6 +98,7 @@ defmodule Eventos.Actors.Actor do
     |> validate_required([:preferred_username, :keys, :suspended, :url, :type])
   end
 
+  # TODO : Use me !
   @email_regex ~r/^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/
   def remote_actor_creation(params) do
     changes =
@@ -219,37 +187,17 @@ defmodule Eventos.Actors.Actor do
     end
   end
 
-  # @spec get_public_key_for_url(Actor.t) :: {:ok, String.t}
+  @spec get_public_key_for_url(String.t()) :: {:ok, String.t()}
   def get_public_key_for_url(url) do
     with %Actor{} = actor <- get_or_fetch_by_url(url) do
-      actor
-      |> get_keys_for_actor
+      actor.keys
       |> Eventos.Service.ActivityPub.Utils.pem_to_public_key()
     else
       _ -> :error
     end
   end
 
-  @deprecated "Use get_keys_for_actor/1 instead"
-  # @spec get_public_key_for_actor(Actor.t) :: {:ok, String.t}
-  def get_public_key_for_actor(%Actor{} = actor) do
-    {:ok, actor.keys}
-  end
-
-  @doc """
-  Returns a pem encoded keypair (if local) or public key
-  """
-  def get_keys_for_actor(%Actor{} = actor) do
-    actor.keys
-  end
-
-  @deprecated "Use get_keys_for_actor/1 instead"
-  # @spec get_private_key_for_actor(Actor.t) :: {:ok, String.t}
-  def get_private_key_for_actor(%Actor{} = actor) do
-    actor.keys
-  end
-
-  def get_followers(%Actor{id: actor_id} = actor) do
+  def get_followers(%Actor{id: actor_id} = _actor) do
     Repo.all(
       from(
         a in Actor,
@@ -260,7 +208,7 @@ defmodule Eventos.Actors.Actor do
     )
   end
 
-  def get_followings(%Actor{id: actor_id} = actor) do
+  def get_followings(%Actor{id: actor_id} = _actor) do
     Repo.all(
       from(
         a in Actor,

lib/eventos/actors/actors.ex

@@ -112,36 +112,21 @@ defmodule Eventos.Actors do
     Actor.changeset(actor, %{})
   end
 
-  @doc """
-  Returns a text representation of a local actor like user@domain.tld
-  """
-  def actor_to_local_name_and_domain(actor) do
-    "#{actor.preferred_username}@#{Application.get_env(:my, EventosWeb.Endpoint)[:url][:host]}"
-  end
-
-  @doc """
-  Returns a webfinger representation of an actor
-  """
-  def actor_to_webfinger_s(actor) do
-    "acct:#{actor_to_local_name_and_domain(actor)}"
-  end
-
   @doc """
   List the groups
   """
   def list_groups do
-    Repo.all(from(a in Actor, where: a.type == "Group"))
+    Repo.all(from(a in Actor, where: a.type == ^:Group))
   end
 
   def get_group_by_name(name) do
-    actor =
-      case String.split(name, "@") do
-        [name] ->
-          Repo.get_by(Actor, preferred_username: name, type: :Group)
+    case String.split(name, "@") do
+      [name] ->
+        Repo.get_by(Actor, preferred_username: name, type: :Group)
 
-        [name, domain] ->
-          Repo.get_by(Actor, preferred_username: name, domain: domain, type: :Group)
-      end
+      [name, domain] ->
+        Repo.get_by(Actor, preferred_username: name, domain: domain, type: :Group)
+    end
   end
 
   @doc """
@@ -736,4 +721,90 @@ defmodule Eventos.Actors do
   def change_bot(%Bot{} = bot) do
     Bot.changeset(bot, %{})
   end
+
+  alias Eventos.Actors.Follower
+
+  @doc """
+  Gets a single follower.
+
+  Raises `Ecto.NoResultsError` if the Follower does not exist.
+
+  ## Examples
+
+      iex> get_follower!(123)
+      %Follower{}
+
+      iex> get_follower!(456)
+      ** (Ecto.NoResultsError)
+
+  """
+  def get_follower!(id) do
+    Repo.get!(Follower, id)
+    |> Repo.preload([:actor, :target_actor])
+  end
+
+  @doc """
+  Creates a follower.
+
+  ## Examples
+
+      iex> create_follower(%{field: value})
+      {:ok, %Follower{}}
+
+      iex> create_follower(%{field: bad_value})
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def create_follower(attrs \\ %{}) do
+    %Follower{}
+    |> Follower.changeset(attrs)
+    |> Repo.insert()
+  end
+
+  @doc """
+  Updates a follower.
+
+  ## Examples
+
+      iex> update_follower(follower, %{field: new_value})
+      {:ok, %Follower{}}
+
+      iex> update_follower(follower, %{field: bad_value})
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def update_follower(%Follower{} = follower, attrs) do
+    follower
+    |> Follower.changeset(attrs)
+    |> Repo.update()
+  end
+
+  @doc """
+  Deletes a Follower.
+
+  ## Examples
+
+      iex> delete_follower(follower)
+      {:ok, %Follower{}}
+
+      iex> delete_follower(follower)
+      {:error, %Ecto.Changeset{}}
+
+  """
+  def delete_follower(%Follower{} = follower) do
+    Repo.delete(follower)
+  end
+
+  @doc """
+  Returns an `%Ecto.Changeset{}` for tracking follower changes.
+
+  ## Examples
+
+      iex> change_follower(follower)
+      %Ecto.Changeset{source: %Follower{}}
+
+  """
+  def change_follower(%Follower{} = follower) do
+    Follower.changeset(follower, %{})
+  end
 end

lib/eventos/actors/follower.ex

@@ -12,14 +12,12 @@ defmodule Eventos.Actors.Follower do
     field(:score, :integer, default: 1000)
     belongs_to(:target_actor, Actor)
     belongs_to(:actor, Actor)
-
-    timestamps()
   end
 
   @doc false
   def changeset(%Follower{} = member, attrs) do
     member
-    |> cast(attrs, [:role, :approved, :target_actor_id, :actor_id])
-    |> validate_required([:role, :approved, :target_actor_id, :actor_id])
+    |> cast(attrs, [:score, :approved, :target_actor_id, :actor_id])
+    |> validate_required([:score, :approved, :target_actor_id, :actor_id])
   end
 end