Various refactoring and typespec improvements

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/web/auth/context.ex

@@ -25,7 +25,7 @@ defmodule Mobilizon.Web.Auth.Context do
   defp set_user_information_in_context(conn) do
     context = %{ip: conn.remote_ip |> :inet.ntoa() |> to_string()}
 
-    user_agent = Plug.Conn.get_req_header(conn, "user-agent") |> List.first()
+    user_agent = conn |> Plug.Conn.get_req_header("user-agent") |> List.first()
 
     {conn, context} =
       case Guardian.Plug.current_resource(conn) do
@@ -41,7 +41,7 @@ defmodule Mobilizon.Web.Auth.Context do
               },
               query_string: conn.query_string,
               env: %{
-                REQUEST_ID: Plug.Conn.get_resp_header(conn, "x-request-id") |> List.first(),
+                REQUEST_ID: conn |> Plug.Conn.get_resp_header("x-request-id") |> List.first(),
                 SERVER_NAME: conn.host
               }
             })

lib/web/auth/guardian.ex

@@ -23,6 +23,8 @@ defmodule Mobilizon.Web.Auth.Guardian do
     {:error, :unknown_resource}
   end
 
+  @spec resource_from_claims(any) ::
+          {:error, :invalid_id | :no_result | :no_claims} | {:ok, Mobilizon.Users.User.t()}
   def resource_from_claims(%{"sub" => "User:" <> uid_str}) do
     Logger.debug(fn -> "Receiving claim for user #{uid_str}" end)
 
@@ -40,7 +42,7 @@ defmodule Mobilizon.Web.Auth.Guardian do
   end
 
   def resource_from_claims(_) do
-    {:error, :reason_for_error}
+    {:error, :no_claims}
   end
 
   def after_encode_and_sign(resource, claims, token, _options) do