Spec improvements

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/mobilizon/actors/member.ex

@@ -8,18 +8,19 @@ defmodule Mobilizon.Actors.Member do
   import Ecto.Changeset
 
   alias Mobilizon.Actors.{Actor, MemberRole}
+  alias Mobilizon.Actors.Member.Metadata
   alias Mobilizon.Web.Endpoint
 
   @type t :: %__MODULE__{
           role: MemberRole.t(),
           parent: Actor.t(),
-          actor: Actor.t()
+          actor: Actor.t(),
+          metadata: Metadata.t()
         }
 
   @required_attrs [:parent_id, :actor_id, :url]
   @optional_attrs [:role, :invited_by_id]
   @attrs @required_attrs ++ @optional_attrs
-  @metadata_attrs []
 
   @primary_key {:id, :binary_id, autogenerate: true}
   schema "members" do
@@ -27,9 +28,7 @@ defmodule Mobilizon.Actors.Member do
     field(:url, :string)
     field(:member_since, :utc_datetime)
 
-    embeds_one :metadata, Metadata, on_replace: :delete do
-      # TODO : Use this space to put notes when someone is invited / requested to join
-    end
+    embeds_one(:metadata, Metadata, on_replace: :delete)
 
     belongs_to(:invited_by, Actor)
     belongs_to(:parent, Actor)
@@ -63,7 +62,7 @@ defmodule Mobilizon.Actors.Member do
   def changeset(%__MODULE__{} = member, attrs) do
     member
     |> cast(attrs, @attrs)
-    |> cast_embed(:metadata, with: &metadata_changeset/2)
+    |> cast_embed(:metadata)
     |> ensure_url()
     |> update_member_since()
     |> validate_required(@required_attrs)
@@ -72,11 +71,6 @@ defmodule Mobilizon.Actors.Member do
     |> unique_constraint(:url, name: :members_url_index)
   end
 
-  defp metadata_changeset(schema, params) do
-    schema
-    |> cast(params, @metadata_attrs)
-  end
-
   # If there's a blank URL that's because we're doing the first insert
   @spec ensure_url(Ecto.Changeset.t()) :: Ecto.Changeset.t()
   defp ensure_url(%Ecto.Changeset{data: %__MODULE__{url: nil}} = changeset) do

lib/mobilizon/actors/member/metadata.ex

@@ -0,0 +1,27 @@
+defmodule Mobilizon.Actors.Member.Metadata do
+  @moduledoc """
+  Represents metadata on a membership
+  """
+
+  use Ecto.Schema
+  import Ecto.Changeset
+
+  @type t :: %__MODULE__{}
+
+  @required_attrs []
+
+  @optional_attrs []
+
+  @attrs @required_attrs ++ @optional_attrs
+
+  embedded_schema do
+    # TODO : Use this space to put notes when someone is invited / requested to join
+  end
+
+  @doc false
+  @spec changeset(t | Ecto.Schema.t(), map) :: Ecto.Changeset.t()
+  def changeset(schema, params) do
+    schema
+    |> cast(params, @attrs)
+  end
+end