Improve group refreshment and fixed date signature generation

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-11-13 18:45:01 +01:00
parent 6d599441a9
commit 55af776df9
27 changed files with 1009 additions and 704 deletions
--- a/test/federation/activity_pub/transmogrifier/comments_test.exs
+++ b/test/federation/activity_pub/transmogrifier/comments_test.exs
@@ -36,12 +36,79 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
    end

    test "it fetches replied-to activities if we don't have them" do
-      data =
-        File.read!("test/fixtures/mastodon-post-activity.json")
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
+      status_data = File.read!("test/fixtures/mastodon-status-2.json") |> Jason.decode!()
+
+      reply_to_data =
+        File.read!("test/fixtures/pleroma-comment-object.json")
        |> Jason.decode!()

      reply_to_url = "https://fedi.absturztau.be/objects/1726cdc7-4f2a-4ddb-9c68-03d27c98c3d9"

+      Mock
+      |> expect(:call, 5, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/admin")
+               |> Map.put("preferredUsername", "admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/tcit")
+               |> Map.put("preferredUsername", "tcit")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/Framasoft"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/Framasoft")
+               |> Map.put("preferredUsername", "Framasoft")
+           }}
+
+        %{
+          method: :get,
+          url: "https://fedi.absturztau.be/objects/1726cdc7-4f2a-4ddb-9c68-03d27c98c3d9"
+        },
+        _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               status_data
+               |> Map.put(
+                 "id",
+                 "https://fedi.absturztau.be/objects/1726cdc7-4f2a-4ddb-9c68-03d27c98c3d9"
+               )
+               |> Map.put("actor", "https://fedi.absturztau.be/users/dqn")
+           }}
+
+        %{method: :get, url: "https://fedi.absturztau.be/users/dqn"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://fedi.absturztau.be/users/dqn")
+           }}
+
+        %{method: :get, url: ^reply_to_url}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: reply_to_data}}
+      end)
+
+      data =
+        File.read!("test/fixtures/mastodon-post-activity.json")
+        |> Jason.decode!()
+
      object =
        data["object"]
        |> Map.put("inReplyTo", reply_to_url)
@@ -50,16 +117,6 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
        data
        |> Map.put("object", object)

-      reply_to_data =
-        File.read!("test/fixtures/pleroma-comment-object.json")
-        |> Jason.decode!()
-
-      Mock
-      |> expect(:call, fn
-        %{method: :get, url: ^reply_to_url}, _opts ->
-          {:ok, %Tesla.Env{status: 200, body: reply_to_data}}
-      end)
-
      {:ok, returned_activity, _} = Transmogrifier.handle_incoming(data)

      %Comment{} =
@@ -75,6 +132,25 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
    end

    test "it doesn't saves replies to an event if the event doesn't accept comments" do
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
+
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://framapiaf.org/users/admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://framapiaf.org/users/tcit")
+           }}
+      end)
+
      data =
        File.read!("test/fixtures/mastodon-post-activity.json")
        |> Jason.decode!()
@@ -94,6 +170,31 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do

    @url_404 "https://404.site/whatever"
    test "it does not crash if the object in inReplyTo can't be fetched" do
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
+
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/admin")
+               |> Map.put("preferredUsername", "admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/tcit")
+               |> Map.put("preferredUsername", "tcit")
+           }}
+      end)
+
      data =
        File.read!("test/fixtures/mastodon-post-activity.json")
        |> Jason.decode!()
@@ -118,6 +219,31 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
    end

    test "it ignores incoming private notes" do
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
+
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/admin")
+               |> Map.put("preferredUsername", "admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/tcit")
+               |> Map.put("preferredUsername", "tcit")
+           }}
+      end)
+
      data = File.read!("test/fixtures/mastodon-post-activity-private.json") |> Jason.decode!()
      event = insert(:event)
      object = data["object"]
@@ -128,16 +254,33 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
    end

    test "it works for incoming notices" do
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
      data = File.read!("test/fixtures/mastodon-post-activity.json") |> Jason.decode!()

+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://framapiaf.org/users/admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://framapiaf.org/users/tcit")
+           }}
+      end)
+
      {:ok, %Activity{data: data, local: false}, _} = Transmogrifier.handle_incoming(data)

      assert data["id"] ==
               "https://framapiaf.org/users/admin/statuses/99512778738411822/activity"

      assert data["to"] == [
-               "https://www.w3.org/ns/activitystreams#Public",
-               "https://framapiaf.org/users/tcit"
+               "https://www.w3.org/ns/activitystreams#Public"
             ]

      #      assert data["cc"] == [
@@ -164,6 +307,31 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
    end

    test "it works for incoming notices with hashtags" do
+      actor_data = File.read!("test/fixtures/mastodon-actor.json") |> Jason.decode!()
+
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/admin")
+               |> Map.put("preferredUsername", "admin")
+           }}
+
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body:
+               actor_data
+               |> Map.put("id", "https://framapiaf.org/users/tcit")
+               |> Map.put("preferredUsername", "tcit")
+           }}
+      end)
+
      data = File.read!("test/fixtures/mastodon-post-activity-hashtag.json") |> Jason.decode!()

      {:ok, %Activity{data: data, local: false}, _} = Transmogrifier.handle_incoming(data)
--- a/test/federation/activity_pub/transmogrifier/delete_test.exs
+++ b/test/federation/activity_pub/transmogrifier/delete_test.exs
@@ -56,6 +56,19 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.DeleteTest do
    end

    test "it fails for incoming deletes with spoofed origin" do
+      actor_data =
+        File.read!("test/fixtures/mastodon-actor.json")
+        |> Jason.decode!()
+
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/peertube"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}
+
+        %{method: :get, url: "http://mastodon.example.org/users/gargron"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}
+      end)
+
      comment = insert(:comment)

      announce_data =
@@ -77,7 +90,7 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.DeleteTest do
        data
        |> Map.put("object", object)

-      {:error, :unknown_actor} = Transmogrifier.handle_incoming(data)
+      :error = Transmogrifier.handle_incoming(data)

      assert Discussions.get_comment_from_url(comment.url)
    end
@@ -132,12 +145,12 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.DeleteTest do
        |> Map.put("id", deleted_actor_url)

      Mock
-      |> expect(:call, fn
+      |> expect(:call, 2, fn
        %{url: ^deleted_actor_url}, _opts ->
          {:ok, %Tesla.Env{status: 200, body: deleted_actor_data}}
      end)

-      assert :error == Transmogrifier.handle_incoming(data)
+      assert {:error, "Group object URL remote"} == Transmogrifier.handle_incoming(data)

      assert Actors.get_actor_by_url(url)
    end
--- a/test/federation/activity_pub/transmogrifier/follow_test.exs
+++ b/test/federation/activity_pub/transmogrifier/follow_test.exs
@@ -1,16 +1,31 @@
 defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.FollowTest do
  use Mobilizon.DataCase
-
+  import Mox
  import ExUnit.CaptureLog
  import Mobilizon.Factory
  alias Mobilizon.Actors
  alias Mobilizon.Actors.Follower
  alias Mobilizon.Federation.ActivityPub.{Actions, Activity, Transmogrifier}
+  alias Mobilizon.Service.HTTP.ActivityPub.Mock

  describe "handle incoming follow requests" do
    test "it works only for groups" do
      actor = insert(:actor)

+      actor_data =
+        File.read!("test/fixtures/mastodon-actor.json")
+        |> Jason.decode!()
+
+      Mock
+      |> expect(:call, fn
+        %{method: :get, url: "https://social.tcit.fr/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://social.tcit.fr/users/tcit")
+           }}
+      end)
+
      data =
        File.read!("test/fixtures/mastodon-follow-activity.json")
        |> Jason.decode!()
@@ -27,6 +42,20 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.FollowTest do
    test "it works for incoming follow requests" do
      actor = insert(:group)

+      actor_data =
+        File.read!("test/fixtures/mastodon-actor.json")
+        |> Jason.decode!()
+
+      Mock
+      |> expect(:call, fn
+        %{method: :get, url: "https://social.tcit.fr/users/tcit"}, _opts ->
+          {:ok,
+           %Tesla.Env{
+             status: 200,
+             body: Map.put(actor_data, "id", "https://social.tcit.fr/users/tcit")
+           }}
+      end)
+
      data =
        File.read!("test/fixtures/mastodon-follow-activity.json")
        |> Jason.decode!()
--- a/test/federation/activity_pub/transmogrifier/undo_test.exs
+++ b/test/federation/activity_pub/transmogrifier/undo_test.exs
@@ -22,9 +22,12 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.UndoTest do
        |> Jason.decode!()

      Mock
-      |> expect(:call, fn
+      |> expect(:call, 2, fn
        %{method: :get, url: "https://framapiaf.org/users/Framasoft"}, _opts ->
          {:ok, %Tesla.Env{status: 200, body: actor_data}}
+
+        %{method: :get, url: "https://framapiaf.org/users/peertube"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}
      end)

      {:ok, _, %Comment{}} = Transmogrifier.handle_incoming(announce_data)
--- a/test/federation/activity_pub/transmogrifier/update_test.exs
+++ b/test/federation/activity_pub/transmogrifier/update_test.exs
@@ -1,8 +1,8 @@
 defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.UpdateTest do
  use Mobilizon.DataCase
-  use ExVCR.Mock, adapter: ExVCR.Adapter.Hackney
  use Oban.Testing, repo: Mobilizon.Storage.Repo
  import Mobilizon.Factory
+  import Mox

  alias Mobilizon.{Actors, Events, Posts}
  alias Mobilizon.Actors.{Actor, Member}
@@ -10,79 +10,100 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.UpdateTest do
  alias Mobilizon.Posts.Post
  alias Mobilizon.Federation.ActivityPub.{Activity, Transmogrifier}
  alias Mobilizon.Federation.ActivityStream.Convertible
+  alias Mobilizon.Service.HTTP.ActivityPub.Mock

  describe "handle incoming update activities" do
    test "it works for incoming update activities on actors" do
-      use_cassette "activity_pub/update_actor_activity" do
-        data = File.read!("test/fixtures/mastodon-post-activity.json") |> Jason.decode!()
+      data = File.read!("test/fixtures/mastodon-post-activity.json") |> Jason.decode!()

-        {:ok, %Activity{data: data, local: false}, _} = Transmogrifier.handle_incoming(data)
-        update_data = File.read!("test/fixtures/mastodon-update.json") |> Jason.decode!()
+      actor_data =
+        File.read!("test/fixtures/mastodon-actor.json")
+        |> Jason.decode!()

-        object =
-          update_data["object"]
-          |> Map.put("actor", data["actor"])
-          |> Map.put("id", data["actor"])
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://framapiaf.org/users/admin"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}

-        update_data =
-          update_data
-          |> Map.put("actor", data["actor"])
-          |> Map.put("object", object)
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}
+      end)

-        {:ok, %Activity{data: _data, local: false}, _} =
-          Transmogrifier.handle_incoming(update_data)
+      {:ok, %Activity{data: data, local: false}, _} = Transmogrifier.handle_incoming(data)
+      update_data = File.read!("test/fixtures/mastodon-update.json") |> Jason.decode!()

-        {:ok, %Actor{} = actor} = Actors.get_actor_by_url(update_data["actor"])
-        assert actor.name == "nextsoft"
+      object =
+        update_data["object"]
+        |> Map.put("actor", data["actor"])
+        |> Map.put("id", data["actor"])

-        assert actor.summary == "<p>Some bio</p>"
-      end
+      update_data =
+        update_data
+        |> Map.put("actor", data["actor"])
+        |> Map.put("object", object)
+
+      {:ok, %Activity{data: _data, local: false}, _} = Transmogrifier.handle_incoming(update_data)
+
+      {:ok, %Actor{} = actor} = Actors.get_actor_by_url(update_data["actor"])
+      assert actor.name == "nextsoft"
+
+      assert actor.summary == "<p>Some bio</p>"
    end

    test "it works for incoming update activities on events" do
-      use_cassette "activity_pub/event_update_activities" do
-        data = File.read!("test/fixtures/mobilizon-post-activity.json") |> Jason.decode!()
+      data = File.read!("test/fixtures/mobilizon-post-activity.json") |> Jason.decode!()

-        {:ok, %Activity{data: data, local: false}, %Event{id: event_id}} =
-          Transmogrifier.handle_incoming(data)
+      actor_data =
+        File.read!("test/fixtures/mastodon-actor.json")
+        |> Jason.decode!()

-        assert_enqueued(
-          worker: Mobilizon.Service.Workers.BuildSearch,
-          args: %{event_id: event_id, op: :insert_search_event}
-        )
+      Mock
+      |> expect(:call, 2, fn
+        %{method: :get, url: "https://mobilizon.fr/@metacartes"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}

-        assert %{success: 1, snoozed: 0, failure: 0} == Oban.drain_queue(queue: :search)
+        %{method: :get, url: "https://framapiaf.org/users/tcit"}, _opts ->
+          {:ok, %Tesla.Env{status: 200, body: actor_data}}
+      end)

-        update_data = File.read!("test/fixtures/mastodon-update.json") |> Jason.decode!()
+      {:ok, %Activity{data: data, local: false}, %Event{id: event_id}} =
+        Transmogrifier.handle_incoming(data)

-        object =
-          data["object"]
-          |> Map.put("actor", data["actor"])
-          |> Map.put("name", "My updated event")
-          |> Map.put("id", data["object"]["id"])
-          |> Map.put("type", "Event")
+      assert_enqueued(
+        worker: Mobilizon.Service.Workers.BuildSearch,
+        args: %{event_id: event_id, op: :insert_search_event}
+      )

-        update_data =
-          update_data
-          |> Map.put("actor", data["actor"])
-          |> Map.put("object", object)
+      assert %{success: 1, snoozed: 0, failure: 0} == Oban.drain_queue(queue: :search)

-        {:ok, %Activity{data: data, local: false}, _} =
-          Transmogrifier.handle_incoming(update_data)
+      update_data = File.read!("test/fixtures/mastodon-update.json") |> Jason.decode!()

-        %Event{} = event = Events.get_event_by_url(data["object"]["id"])
+      object =
+        data["object"]
+        |> Map.put("actor", data["actor"])
+        |> Map.put("name", "My updated event")
+        |> Map.put("id", data["object"]["id"])
+        |> Map.put("type", "Event")

-        assert_enqueued(
-          worker: Mobilizon.Service.Workers.BuildSearch,
-          args: %{event_id: event_id, op: :update_search_event}
-        )
+      update_data =
+        update_data
+        |> Map.put("actor", data["actor"])
+        |> Map.put("object", object)

-        assert %{success: 1, snoozed: 0, failure: 0} == Oban.drain_queue(queue: :search)
+      {:ok, %Activity{data: data, local: false}, _} = Transmogrifier.handle_incoming(update_data)

-        assert event.title == "My updated event"
+      %Event{} = event = Events.get_event_by_url(data["object"]["id"])

-        assert event.description == data["object"]["content"]
-      end
+      assert_enqueued(
+        worker: Mobilizon.Service.Workers.BuildSearch,
+        args: %{event_id: event_id, op: :update_search_event}
+      )
+
+      assert %{success: 1, snoozed: 0, failure: 0} == Oban.drain_queue(queue: :search)
+
+      assert event.title == "My updated event"
+
+      assert event.description == data["object"]["content"]
    end

    #     test "it works for incoming update activities which lock the account" do