WIP notification settings

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/service/activity/comment.ex

@@ -2,12 +2,12 @@ defmodule Mobilizon.Service.Activity.Comment do
   @moduledoc """
   Insert a comment activity
   """
-  alias Mobilizon.{Actors, Discussions, Events}
+  alias Mobilizon.{Discussions, Events}
   alias Mobilizon.Actors.Actor
   alias Mobilizon.Discussions.Comment
   alias Mobilizon.Events.Event
   alias Mobilizon.Service.Activity
-  alias Mobilizon.Service.Workers.ActivityBuilder
+  alias Mobilizon.Service.Workers.{ActivityBuilder, LegacyNotifierBuilder}
 
   @behaviour Activity
 
@@ -17,33 +17,21 @@ defmodule Mobilizon.Service.Activity.Comment do
   def insert_activity(
         %Comment{
           actor_id: actor_id,
-          event_id: event_id,
-          in_reply_to_comment_id: in_reply_to_comment_id
+          event_id: event_id
         } = comment,
         options
       )
       when not is_nil(actor_id) and not is_nil(event_id) do
-    with {:ok, %Event{attributed_to: %Actor{type: :Group} = group} = event} <-
-           Events.get_event_with_preload(event_id),
-         %Actor{id: actor_id} <- Actors.get_actor(actor_id),
-         subject <- Keyword.fetch!(options, :subject) do
-      ActivityBuilder.enqueue(:build_activity, %{
-        "type" => "event",
-        "subject" => subject,
-        "subject_params" => %{
-          event_title: event.title,
-          event_uuid: event.uuid,
-          comment_reply_to: !is_nil(in_reply_to_comment_id)
-        },
-        "group_id" => group.id,
-        "author_id" => actor_id,
-        "object_type" => "comment",
-        "object_id" => to_string(comment.id),
-        "inserted_at" => DateTime.utc_now()
-      })
-    else
-      # Event not from group
-      {:ok, %Event{}} -> {:ok, nil}
+    with {:ok, %Event{} = event} <-
+           Events.get_event_with_preload(event_id) do
+      # Notify the actors mentionned
+      notify_mentionned(comment, event)
+
+      # Notify participants if there's a new announcement
+      notify_announcement(comment, event)
+
+      # Notify event organizer or group that there's new comments
+      notify_organizer(comment, event, options)
     end
   end
 
@@ -53,4 +41,116 @@ defmodule Mobilizon.Service.Activity.Comment do
   def get_object(comment_id) do
     Discussions.get_comment(comment_id)
   end
+
+  defp notify_mentionned(%Comment{actor_id: actor_id, id: comment_id, mentions: mentions}, %Event{
+         uuid: uuid,
+         title: title
+       })
+       when length(mentions) > 0 do
+    LegacyNotifierBuilder.enqueue(:legacy_notify, %{
+      "type" => :comment,
+      "subject" => :event_comment_mention,
+      "subject_params" => %{
+        event_uuid: uuid,
+        event_title: title
+      },
+      "author_id" => actor_id,
+      "object_type" => :comment,
+      "object_id" => to_string(comment_id),
+      "inserted_at" => DateTime.utc_now(),
+      "mentions" => Enum.map(mentions, & &1.actor_id)
+    })
+  end
+
+  defp notify_mentionned(_, _), do: {:ok, :skipped}
+
+  defp notify_announcement(
+         %Comment{actor_id: actor_id, is_announcement: true, id: comment_id},
+         %Event{
+           id: event_id,
+           uuid: uuid,
+           title: title
+         }
+       ) do
+    LegacyNotifierBuilder.enqueue(:legacy_notify, %{
+      "type" => :comment,
+      "subject" => :participation_event_comment,
+      "subject_params" => %{
+        event_id: event_id,
+        event_uuid: uuid,
+        event_title: title
+      },
+      "author_id" => actor_id,
+      "object_type" => :comment,
+      "object_id" => to_string(comment_id),
+      "inserted_at" => DateTime.utc_now()
+    })
+  end
+
+  defp notify_announcement(_, _), do: {:ok, :skipped}
+
+  @spec notify_organizer(Comment.t(), Event.t(), Keyword.t()) ::
+          {:ok, Oban.Job.t()} | {:ok, :skipped}
+  defp notify_organizer(
+         %Comment{
+           actor_id: actor_id,
+           is_announcement: true,
+           in_reply_to_comment_id: in_reply_to_comment_id,
+           id: comment_id
+         },
+         %Event{
+           uuid: uuid,
+           title: title,
+           attributed_to: %Actor{type: :Group, id: group_id}
+         },
+         options
+       ) do
+    ActivityBuilder.enqueue(:build_activity, %{
+      "type" => "event",
+      "subject" => Keyword.fetch!(options, :subject),
+      "subject_params" => %{
+        event_title: title,
+        event_uuid: uuid,
+        comment_reply_to: !is_nil(in_reply_to_comment_id)
+      },
+      "group_id" => group_id,
+      "author_id" => actor_id,
+      "object_type" => "comment",
+      "object_id" => to_string(comment_id),
+      "inserted_at" => DateTime.utc_now()
+    })
+  end
+
+  defp notify_organizer(
+         %Comment{
+           actor_id: actor_id,
+           is_announcement: true,
+           in_reply_to_comment_id: in_reply_to_comment_id,
+           id: comment_id
+         },
+         %Event{
+           uuid: uuid,
+           title: title,
+           attributed_to: nil,
+           organizer_actor_id: organizer_actor_id
+         },
+         _options
+       )
+       when actor_id !== organizer_actor_id do
+    LegacyNotifierBuilder.enqueue(:legacy_notify, %{
+      "type" => :comment,
+      "subject" => :event_new_comment,
+      "subject_params" => %{
+        event_title: title,
+        event_uuid: uuid,
+        comment_reply_to: !is_nil(in_reply_to_comment_id)
+      },
+      "author_id" => actor_id,
+      "object_type" => :comment,
+      "object_id" => to_string(comment_id),
+      "inserted_at" => DateTime.utc_now()
+    })
+  end
+
+  defp notify_organizer(_, _, _), do: {:ok, :skipped}
 end

lib/service/activity/renderer/comment.ex

@@ -0,0 +1,111 @@
+defmodule Mobilizon.Service.Activity.Renderer.Comment do
+  @moduledoc """
+  Insert a comment activity
+  """
+  alias Mobilizon.Activities.Activity
+  alias Mobilizon.Actors.Actor
+  alias Mobilizon.Service.Activity.Renderer
+  alias Mobilizon.Web.{Endpoint, Gettext}
+  alias Mobilizon.Web.Router.Helpers, as: Routes
+  import Mobilizon.Web.Gettext, only: [dgettext: 3]
+
+  @behaviour Renderer
+
+  @impl Renderer
+  def render(%Activity{} = activity, options) do
+    locale = Keyword.get(options, :locale, "en")
+    Gettext.put_locale(locale)
+    profile = profile(activity)
+
+    case activity.subject do
+      :event_comment_mention ->
+        %{
+          body:
+            dgettext(
+              "activity",
+              "%{profile} mentionned you in a comment under event %{event}.",
+              %{
+                profile: profile,
+                event: event_title(activity)
+              }
+            ),
+          url: event_url(activity)
+        }
+
+      :participation_event_comment ->
+        %{
+          body:
+            dgettext(
+              "activity",
+              "%{profile} has posted an announcement under event %{event}.",
+              %{
+                profile: profile,
+                event: event_title(activity)
+              }
+            ),
+          url: event_url(activity)
+        }
+
+      :discussion_mention ->
+        %{
+          body:
+            dgettext("activity", "%{profile} mentionned you in the discussion %{discussion}.", %{
+              profile: profile,
+              discussion: title(activity)
+            }),
+          url: discussion_url(activity)
+        }
+
+      :discussion_renamed ->
+        %{
+          body:
+            dgettext("activity", "%{profile} renamed the discussion %{discussion}.", %{
+              profile: profile,
+              discussion: title(activity)
+            }),
+          url: discussion_url(activity)
+        }
+
+      :discussion_archived ->
+        %{
+          body:
+            dgettext("activity", "%{profile} archived the discussion %{discussion}.", %{
+              profile: profile,
+              discussion: title(activity)
+            }),
+          url: discussion_url(activity)
+        }
+
+      :discussion_deleted ->
+        %{
+          body:
+            dgettext("activity", "%{profile} deleted the discussion %{discussion}.", %{
+              profile: profile,
+              discussion: title(activity)
+            }),
+          url: nil
+        }
+    end
+  end
+
+  defp discussion_url(activity) do
+    Routes.page_url(
+      Endpoint,
+      :discussion,
+      Actor.preferred_username_and_domain(activity.group),
+      activity.subject_params["discussion_slug"]
+    )
+  end
+
+  defp event_url(activity) do
+    Routes.page_url(
+      Endpoint,
+      :event,
+      activity.subject_params["event_uuid"]
+    )
+  end
+
+  defp profile(activity), do: Actor.display_name_and_username(activity.author)
+  defp event_title(activity), do: activity.subject_params["event_title"]
+  defp title(activity), do: activity.subject_params["discussion_title"]
+end

lib/service/activity/renderer/renderer.ex

@@ -5,7 +5,17 @@ defmodule Mobilizon.Service.Activity.Renderer do
 
   alias Mobilizon.Config
   alias Mobilizon.Activities.Activity
-  alias Mobilizon.Service.Activity.Renderer.{Discussion, Event, Group, Member, Post, Resource}
+
+  alias Mobilizon.Service.Activity.Renderer.{
+    Comment,
+    Discussion,
+    Event,
+    Group,
+    Member,
+    Post,
+    Resource
+  }
+
   require Logger
   import Mobilizon.Web.Gettext, only: [dgettext: 3]
 
@@ -41,6 +51,7 @@ defmodule Mobilizon.Service.Activity.Renderer do
       :member -> Member.render(activity, options)
       :post -> Post.render(activity, options)
       :resource -> Resource.render(activity, options)
+      :comment -> Comment.render(activity, options)
       _ -> nil
     end
   end