Validate ends_on being after begins_on

Closes #315

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/service/activity_pub/activity_pub.ex

@@ -93,8 +93,6 @@ defmodule Mobilizon.Service.ActivityPub do
         {:ok, Actors.get_actor_by_url!(actor_url, true)}
 
       e ->
-        require Logger
-        Logger.error(inspect(e))
         {:error, e}
     end
   end
@@ -135,14 +133,13 @@ defmodule Mobilizon.Service.ActivityPub do
     Logger.debug("creating an activity")
     Logger.debug(inspect(args))
 
-    {:ok, entity, create_data} =
-      case type do
-        :event -> create_event(args, additional)
-        :comment -> create_comment(args, additional)
-        :group -> create_group(args, additional)
-      end
-
-    with {:ok, activity} <- create_activity(create_data, local),
+    with {:ok, entity, create_data} <-
+           (case type do
+              :event -> create_event(args, additional)
+              :comment -> create_comment(args, additional)
+              :group -> create_group(args, additional)
+            end),
+         {:ok, activity} <- create_activity(create_data, local),
          :ok <- maybe_federate(activity) do
       {:ok, activity, entity}
     else
@@ -167,13 +164,12 @@ defmodule Mobilizon.Service.ActivityPub do
     Logger.debug("updating an activity")
     Logger.debug(inspect(args))
 
-    {:ok, entity, update_data} =
-      case type do
-        :event -> update_event(old_entity, args, additional)
-        :actor -> update_actor(old_entity, args, additional)
-      end
-
-    with {:ok, activity} <- create_activity(update_data, local),
+    with {:ok, entity, update_data} <-
+           (case type do
+              :event -> update_event(old_entity, args, additional)
+              :actor -> update_actor(old_entity, args, additional)
+            end),
+         {:ok, activity} <- create_activity(update_data, local),
          :ok <- maybe_federate(activity) do
       {:ok, activity, entity}
     else

lib/service/activity_pub/transmogrifier.ex

@@ -339,8 +339,7 @@ defmodule Mobilizon.Service.ActivityPub.Transmogrifier do
            ActivityPub.update(:event, old_event, object_data, false) do
       {:ok, activity, new_event}
     else
-      e ->
-        Logger.error(inspect(e))
+      _e ->
         :error
     end
   end
@@ -442,8 +441,7 @@ defmodule Mobilizon.Service.ActivityPub.Transmogrifier do
 
         :error
 
-      e ->
-        Logger.error(inspect(e))
+      _e ->
         :error
     end
   end