refactor: rename externalUrls to externalLinks

src/components/NavBar.vue

@@ -68,7 +68,7 @@
               >{{ t("Register") }}</router-link
             >
           </li>
-          <li v-for="(link, index) in externalURLSConfig" :key="index">
+          <li v-for="(link, index) in externalLinksConfig" :key="index">
             <a
               :href="link.url"
               v-if="link.enabled"
@@ -279,7 +279,7 @@ import { useLazyQuery, useMutation } from "@vue/apollo-composable";
 import { UPDATE_DEFAULT_ACTOR } from "@/graphql/actor";
 import { changeIdentity } from "@/utils/identity";
 import {
-  useExternalURLSConfig,
+  useExternalLinksConfig,
   useRegistrationConfig,
 } from "@/composition/apollo/config";
 import { useOruga } from "@oruga-ui/oruga-next";
@@ -296,7 +296,7 @@ const { identities } = useCurrentUserIdentities();
 const router = useRouter();
 const route = useRoute();
 
-const { externalURLSConfig } = useExternalURLSConfig();
+const { externalLinksConfig } = useExternalLinksConfig();
 const { registrationsOpen, registrationsAllowlist, databaseLogin } =
   useRegistrationConfig();
 

src/composition/apollo/config.ts

@@ -32,20 +32,20 @@ export function useAnonymousParticipationConfig() {
   return { anonymousParticipationConfig, error, loading };
 }
 
-export function useExternalURLSConfig() {
+export function useExternalLinksConfig() {
   const {
     result: configResult,
     error,
     loading,
   } = useQuery<{
-    config: Pick<IConfig, "externalUrls">;
+    config: Pick<IConfig, "externalLinks">;
   }>(CONFIG);
 
-  const externalURLSConfig = computed(
-    () => configResult.value?.config?.externalUrls
+  const externalLinksConfig = computed(
+    () => configResult.value?.config?.externalLinks
   );
 
-  return { externalURLSConfig, error, loading };
+  return { externalLinksConfig, error, loading };
 }
 
 export function useAnonymousReportsConfig() {

src/graphql/admin.ts

@@ -200,7 +200,7 @@ export const ADMIN_SETTINGS_FRAGMENT = gql`
     instanceLongDescription
     instanceSlogan
     contact
-    externalUrls {
+    externalLinks {
       label
       url
       enabled
@@ -251,7 +251,7 @@ export const SAVE_ADMIN_SETTINGS = gql`
     $instanceLongDescription: String
     $instanceSlogan: String
     $contact: String
-    $externalUrls: [ExternalUrlInput]
+    $externalLinks: [ExternalLinkInput]
     $instanceLogo: MediaInput
     $instanceFavicon: MediaInput
     $defaultPicture: MediaInput
@@ -274,7 +274,7 @@ export const SAVE_ADMIN_SETTINGS = gql`
       instanceLongDescription: $instanceLongDescription
       instanceSlogan: $instanceSlogan
       contact: $contact
-      externalUrls: $externalUrls
+      externalLinks: $externalLinks
       instanceLogo: $instanceLogo
       instanceFavicon: $instanceFavicon
       defaultPicture: $defaultPicture

src/graphql/config.ts

@@ -20,7 +20,7 @@ export const CONFIG = gql`
       languages
       primaryColor
       secondaryColor
-      externalUrls {
+      externalLinks {
         label
         url
         enabled

src/types/admin.model.ts

@@ -28,7 +28,7 @@ export interface IAdminSettings {
   contact: string;
   instanceLogo: IMedia | null;
   instanceFavicon: IMedia | null;
-  externalUrls: { url: string; label: string; enabled: boolean }[];
+  externalLinks: { url: string; label: string; enabled: boolean }[];
   defaultPicture: IMedia | null;
   primaryColor: string;
   secondaryColor: string;

src/types/config.model.ts

@@ -37,7 +37,7 @@ export interface IConfig {
   longDescription: string;
   contact: string;
   slogan: string;
-  externalUrls: { url: string; label: string; enabled: boolean }[];
+  externalLinks: { url: string; label: string; enabled: boolean }[];
   instanceLogo: { url: string };
   defaultPicture: { url: string };
   primaryColor: string;

src/views/Admin/SettingsView.vue

@@ -472,11 +472,11 @@
           </o-field>
           <div
             class="mt-5 grid lg:grid-cols-[repeat(auto-fit,minmax(250px,0.5fr))] grid-cols-[repeat(auto-fit,minmax(250px,1fr))] gap-2"
-            v-if="settingsToWrite.externalUrls.length > 0"
+            v-if="settingsToWrite.externalLinks.length > 0"
           >
             <div
               class="bg-mbz-yellow-alt-100 p-5"
-              v-for="(link, index) in settingsToWrite.externalUrls"
+              v-for="(link, index) in settingsToWrite.externalLinks"
               :key="index"
             >
               <o-field :label="t('URL')" class="!mt-0"
@@ -556,7 +556,7 @@ const defaultAdminSettings: IAdminSettings = {
   registrationsOpen: false,
   registrationsModeration: false,
   instanceLanguages: [],
-  externalUrls: [],
+  externalLinks: [],
 };
 
 const { onResult: onAdminSettingsResult } = useQuery<{
@@ -598,15 +598,15 @@ useHead({
 const settingsToWrite = ref<IAdminSettings>(defaultAdminSettings);
 
 watch(adminSettings, () => {
-  // We need to use structuredClone to clone deep properties of adminSettings (like externalUrls)
-  // {... } only shadow clone, so externalUrls is not reactive doing this
+  // We need to use structuredClone to clone deep properties of adminSettings (like externalLinks)
+  // {... } only shadow clone, so externalLinks is not reactive doing this
   if (adminSettings.value) {
     settingsToWrite.value = structuredClone(toRaw(adminSettings.value));
   }
 });
 
 const addLink = () => {
-  settingsToWrite.value.externalUrls.push({
+  settingsToWrite.value.externalLinks.push({
     url: "",
     label: "",
     enabled: false,
@@ -614,7 +614,7 @@ const addLink = () => {
 };
 
 const deleteLink = (index: number) => {
-  settingsToWrite.value.externalUrls.splice(index, 1);
+  settingsToWrite.value.externalLinks.splice(index, 1);
 };
 
 const filteredLanguages = ref<string[]>([]);