Allow to join an open group

Also:

* Refactor interacting with a remote event so that you can interact with
  a remote group as well
* Add a setting for group admins to pick between an open and invite-only
  group
* Fix new groups without posts/todos/resources/events/conversations URL
  set
* Repair local groups that haven't got their
  posts/todos/resources/events/conversations URL set
* Add a scheduled job to refresh remote groups every hour
* Add a user setting to pick when to receive notifications when there's
  new members to approve (will be used when this feature is available)
* Fix pagination for members

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/graphql/resolvers/discussion.ex

@@ -75,7 +75,7 @@ defmodule Mobilizon.GraphQL.Resolvers.Discussion do
 
   def create_discussion(
         _parent,
-        %{title: title, text: text, actor_id: actor_id},
+        %{title: title, text: text, actor_id: group_id},
         %{
           context: %{
             current_user: %User{} = user
@@ -83,20 +83,23 @@ defmodule Mobilizon.GraphQL.Resolvers.Discussion do
         }
       ) do
     with {:actor, %Actor{id: creator_id} = _actor} <- {:actor, Users.get_actor_for_user(user)},
-         {:member, true} <- {:member, Actors.is_member?(creator_id, actor_id)},
+         {:member, true} <- {:member, Actors.is_member?(creator_id, group_id)},
          {:ok, _activity, %Discussion{} = discussion} <-
            ActivityPub.create(
              :discussion,
              %{
                title: title,
                text: text,
-               actor_id: actor_id,
+               actor_id: group_id,
                creator_id: creator_id,
-               attributed_to_id: actor_id
+               attributed_to_id: group_id
              },
              true
            ) do
       {:ok, discussion}
+    else
+      {:member, false} ->
+        {:error, :unauthorized}
     end
   end
 

lib/graphql/resolvers/group.ex

@@ -215,35 +215,18 @@ defmodule Mobilizon.GraphQL.Resolvers.Group do
   @doc """
   Join an existing group
   """
-  def join_group(
-        _parent,
-        %{group_id: group_id, actor_id: actor_id},
-        %{
-          context: %{
-            current_user: user
-          }
-        }
-      ) do
-    with {actor_id, ""} <- Integer.parse(actor_id),
-         {group_id, ""} <- Integer.parse(group_id),
-         {:is_owned, %Actor{} = actor} <- User.owns_actor(user, actor_id),
-         {:ok, %Actor{} = group} <- Actors.get_group_by_actor_id(group_id),
+  def join_group(_parent, %{group_id: group_id} = args, %{
+        context: %{current_user: %User{} = user}
+      }) do
+    with %Actor{} = actor <- Users.get_actor_for_user(user),
+         {:ok, %Actor{type: :Group} = group} <-
+           Actors.get_group_by_actor_id(group_id),
          {:error, :member_not_found} <- Actors.get_member(actor.id, group.id),
          {:is_able_to_join, true} <- {:is_able_to_join, Member.can_be_joined(group)},
-         role <- Member.get_default_member_role(group),
-         {:ok, _} <- Actors.create_member(%{parent_id: group.id, actor_id: actor.id, role: role}) do
-      {
-        :ok,
-        %{
-          parent: Person.proxify_pictures(group),
-          actor: Person.proxify_pictures(actor),
-          role: role
-        }
-      }
+         {:ok, _activity, %Member{} = member} <-
+           ActivityPub.join(group, actor, true, args) do
+      {:ok, member}
     else
-      {:is_owned, nil} ->
-        {:error, dgettext("errors", "Profile is not owned by authenticated user")}
-
       {:error, :group_not_found} ->
         {:error, dgettext("errors", "Group not found")}
 

lib/graphql/resolvers/search.ex

@@ -25,4 +25,8 @@ defmodule Mobilizon.GraphQL.Resolvers.Search do
   def search_events(_parent, %{page: page, limit: limit} = args, _resolution) do
     Search.search_events(args, page, limit)
   end
+
+  def interact(_parent, %{uri: uri}, _resolution) do
+    Search.interact(uri)
+  end
 end