Edit events fixes and update cache

lib/mobilizon_web/api/utils.ex

@@ -135,7 +135,7 @@ defmodule MobilizonWeb.API.Utils do
   end
 
   def prepare_content(actor, content, visibility, tags, in_reply_to) do
-    with content <- String.trim(content),
+    with content <- String.trim(content || ""),
          {content_html, mentions, tags} <-
            make_content_html(
              content,

lib/mobilizon_web/resolvers/event.ex

@@ -196,9 +196,9 @@ defmodule MobilizonWeb.Resolvers.Event do
     # See https://github.com/absinthe-graphql/absinthe/issues/490
     with args <- Map.put(args, :options, args[:options] || %{}),
          {:is_owned, true, organizer_actor} <- User.owns_actor(user, organizer_actor_id),
-         {:ok, args} <- save_attached_picture(args),
-         {:ok, args} <- save_physical_address(args),
          args_with_organizer <- Map.put(args, :organizer_actor, organizer_actor),
+         {:ok, args_with_organizer} <- save_attached_picture(args_with_organizer),
+         {:ok, args_with_organizer} <- save_physical_address(args_with_organizer),
          {
            :ok,
            %Activity{
@@ -236,9 +236,9 @@ defmodule MobilizonWeb.Resolvers.Event do
     with args <- Map.put(args, :options, args[:options] || %{}),
          {:ok, %Event{} = event} <- Mobilizon.Events.get_event_full(event_id),
          {:is_owned, true, organizer_actor} <- User.owns_actor(user, event.organizer_actor_id),
+         args <- Map.put(args, :organizer_actor, organizer_actor),
          {:ok, args} <- save_attached_picture(args),
          {:ok, args} <- save_physical_address(args),
-         args <- Map.put(args, :organizer_actor, organizer_actor),
          {
            :ok,
            %Activity{
@@ -274,7 +274,7 @@ defmodule MobilizonWeb.Resolvers.Event do
            }
          } = args
        ) do
-    {:ok, Map.put(args, :picture, Map.put(all_pic, :actor_id, args.organizer_actor_id))}
+    {:ok, Map.put(args, :picture, Map.put(all_pic, :actor_id, args.organizer_actor.id))}
   end
 
   # Otherwise if we use a previously uploaded picture we need to fetch it from database
@@ -310,7 +310,7 @@ defmodule MobilizonWeb.Resolvers.Event do
   end
 
   @spec save_physical_address(map()) :: {:ok, map()}
-  defp save_physical_address(%{physical_address: address} = args) do
+  defp save_physical_address(%{physical_address: address} = args) when address != nil do
     with {:ok, %Address{} = address} <- Addresses.create_address(address),
          args <- Map.put(args, :physical_address, address.url) do
       {:ok, args}

lib/mobilizon_web/schema/event.ex

@@ -36,8 +36,8 @@ defmodule MobilizonWeb.Schema.EventType do
       description: "The type of the event's address"
     )
 
-    field(:online_address, :online_address, description: "Online address of the event")
-    field(:phone_address, :phone_address, description: "Phone address for the event")
+    field(:online_address, :string, description: "Online address of the event")
+    field(:phone_address, :string, description: "Phone address for the event")
 
     field(:organizer_actor, :actor,
       resolve: dataloader(Actors),
@@ -208,9 +208,7 @@ defmodule MobilizonWeb.Schema.EventType do
       arg(:description, non_null(:string))
       arg(:begins_on, non_null(:datetime))
       arg(:ends_on, :datetime)
-      arg(:state, :integer)
-      arg(:status, :integer)
-      arg(:public, :boolean)
+      arg(:status, :event_status)
       arg(:visibility, :event_visibility, default_value: :private)
 
       arg(:tags, list_of(:string),
@@ -242,11 +240,8 @@ defmodule MobilizonWeb.Schema.EventType do
       arg(:description, :string)
       arg(:begins_on, :datetime)
       arg(:ends_on, :datetime)
-      arg(:state, :integer)
-      arg(:status, :integer)
-      arg(:public, :boolean)
+      arg(:status, :event_status)
       arg(:visibility, :event_visibility)
-      arg(:organizer_actor_id, :id)
 
       arg(:tags, list_of(:string), description: "The list of tags associated to the event")
 
@@ -255,7 +250,6 @@ defmodule MobilizonWeb.Schema.EventType do
           "The picture for the event, either as an object or directly the ID of an existing Picture"
       )
 
-      arg(:publish_at, :datetime)
       arg(:online_address, :string)
       arg(:phone_address, :string)
       arg(:category, :string)