Add basic metadata to opengraph preview
Also refactor datetime & address utils Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This commit is contained in:
Thomas Citharel
58
test/service/address/address_test.exs
Normal file
58
test/service/address/address_test.exs
Normal file
@@ -0,0 +1,58 @@
|
||||
defmodule Mobilizon.Service.AddressTest do
|
||||
@moduledoc """
|
||||
Test representing addresses
|
||||
"""
|
||||
use Mobilizon.DataCase
|
||||
alias Mobilizon.Addresses.Address
|
||||
alias Mobilizon.Service.Address, as: AddressRenderer
|
||||
import Mobilizon.Factory
|
||||
|
||||
describe "render an address" do
|
||||
test "basic" do
|
||||
%Address{} = address = insert(:address)
|
||||
|
||||
assert AddressRenderer.render_address(address) ==
|
||||
"#{address.description}, #{address.postal_code}, #{address.locality}, #{address.country}"
|
||||
end
|
||||
|
||||
test "a house" do
|
||||
assert AddressRenderer.render_address(%Address{
|
||||
description: "somewhere",
|
||||
type: "house",
|
||||
postal_code: "35000",
|
||||
locality: "Rennes"
|
||||
}) ==
|
||||
"somewhere, 35000, Rennes"
|
||||
end
|
||||
|
||||
test "a city" do
|
||||
assert AddressRenderer.render_address(%Address{
|
||||
description: "Rennes",
|
||||
type: "city",
|
||||
postal_code: "35000",
|
||||
locality: "Rennes"
|
||||
}) ==
|
||||
"Rennes (35000)"
|
||||
end
|
||||
|
||||
test "a region" do
|
||||
assert AddressRenderer.render_address(%Address{
|
||||
description: "Ille et Vilaine",
|
||||
type: "administrative",
|
||||
postal_code: "",
|
||||
locality: ""
|
||||
}) ==
|
||||
"Ille et Vilaine"
|
||||
end
|
||||
|
||||
test "only with description" do
|
||||
assert AddressRenderer.render_address(%Address{description: "somewhere"}) == "somewhere"
|
||||
end
|
||||
|
||||
test "with no data" do
|
||||
assert_raise ArgumentError, "Invalid address", fn ->
|
||||
AddressRenderer.render_address(%Address{})
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
71
test/service/date_time/date_time.exs
Normal file
71
test/service/date_time/date_time.exs
Normal file
@@ -0,0 +1,71 @@
|
||||
defmodule Mobilizon.Service.DateTimeTest do
|
||||
@moduledoc """
|
||||
Test representing datetimes in defined locale
|
||||
"""
|
||||
use Mobilizon.DataCase
|
||||
alias Mobilizon.Service.DateTime, as: DateTimeRenderer
|
||||
|
||||
@datetime "2021-06-22T15:25:29.531539Z"
|
||||
|
||||
describe "render a datetime to string" do
|
||||
test "standard datetime" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
assert DateTimeRenderer.datetime_to_string(datetime) == "Jun 22, 2021, 3:25:29 PM"
|
||||
assert DateTimeRenderer.datetime_to_string(datetime, "fr") == "22 juin 2021, 15:25:29"
|
||||
|
||||
assert DateTimeRenderer.datetime_to_string(datetime, "fr", :long) ==
|
||||
"22 juin 2021 à 15:25:29 UTC"
|
||||
end
|
||||
|
||||
test "non existing or loaded locale fallbacks to english" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
|
||||
assert DateTimeRenderer.datetime_to_string(datetime, "es") == "Jun 22, 2021, 3:25:29 PM"
|
||||
end
|
||||
end
|
||||
|
||||
describe "render a time to string" do
|
||||
test "standard time" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
assert DateTimeRenderer.datetime_to_time_string(datetime) == "3:25 PM"
|
||||
assert DateTimeRenderer.datetime_to_time_string(datetime, "fr") == "15:25"
|
||||
end
|
||||
|
||||
test "non existing or loaded locale fallbacks to english" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
|
||||
assert DateTimeRenderer.datetime_to_time_string(datetime, "pl") == "3:25 PM"
|
||||
end
|
||||
end
|
||||
|
||||
describe "convert a datetime with a timezone" do
|
||||
test "with an existing tz" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
converted_datetime = DateTimeRenderer.datetime_tz_convert(datetime, "Europe/Paris")
|
||||
|
||||
assert %DateTime{time_zone: "Europe/Paris", utc_offset: 3600} = converted_datetime
|
||||
assert converted_datetime |> DateTime.to_unix() == datetime |> DateTime.to_unix()
|
||||
end
|
||||
|
||||
test "with an non existing tz" do
|
||||
{:ok, datetime, _} = DateTime.from_iso8601(@datetime)
|
||||
converted_datetime = DateTimeRenderer.datetime_tz_convert(datetime, "Planet/Mars")
|
||||
|
||||
assert converted_datetime == datetime
|
||||
end
|
||||
end
|
||||
|
||||
describe "gets relative time to a datetime" do
|
||||
test "standard time" do
|
||||
then = DateTime.add(DateTime.utc_now(), 3600 * -5)
|
||||
assert DateTimeRenderer.datetime_relative(then) == "5 hours ago"
|
||||
assert DateTimeRenderer.datetime_relative(then, "fr") == "il y a 5 heures"
|
||||
end
|
||||
|
||||
test "non existing or loaded locale fallbacks to english" do
|
||||
then = DateTime.add(DateTime.utc_now(), 3600 * -4)
|
||||
|
||||
assert DateTimeRenderer.datetime_relative(then, "pl") == "4 hours ago"
|
||||
end
|
||||
end
|
||||
end
|
||||
@@ -6,6 +6,7 @@ defmodule Mobilizon.Service.MetadataTest do
|
||||
alias Mobilizon.Service.Metadata
|
||||
alias Mobilizon.Tombstone
|
||||
alias Mobilizon.Web.Endpoint
|
||||
alias Mobilizon.Web.JsonLD.ObjectView
|
||||
alias Mobilizon.Web.Router.Helpers, as: Routes
|
||||
use Mobilizon.DataCase
|
||||
import Mobilizon.Factory
|
||||
@@ -37,29 +38,81 @@ defmodule Mobilizon.Service.MetadataTest do
|
||||
end
|
||||
|
||||
describe "build_tags/2 for an event" do
|
||||
@long_description """
|
||||
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer malesuada commodo nunc, dictum dignissim erat aliquet quis. Morbi iaculis scelerisque magna eu dapibus. Morbi ultricies mollis arcu, vel auctor enim dapibus ut. Cras tempus sapien eu lacus blandit suscipit. Fusce tincidunt fringilla velit non elementum. Etiam pretium venenatis placerat. Suspendisse interdum, justo efficitur faucibus commodo, dolor elit vehicula lacus, eu molestie nulla mi vel dolor. Nullam fringilla at lorem a gravida. Praesent viverra, ante eu porttitor rutrum, ex leo condimentum felis, vitae vestibulum neque turpis in nunc. Nullam aliquam rhoncus ornare. Suspendisse finibus finibus est sed eleifend. Nam a massa vestibulum, mollis lorem vel, placerat purus. Nam ex nunc, hendrerit ut lacinia ac, pellentesque eu est.</p>
|
||||
|
||||
<p>Fusce nec odio tellus. Aliquam at fermentum turpis, ut dictum tellus. Fusce ac nibh vehicula, imperdiet ipsum sit amet, pellentesque dui. Vivamus venenatis efficitur elementum. Quisque mattis dui ac faucibus mollis. Nullam ac malesuada nisi, vitae scelerisque nisi. Nulla placerat nunc non convallis sollicitudin. Donec sed pulvinar leo, quis tristique eros. Nulla pretium elit ante, consectetur aliquam sapien varius nec. Donec cursus, orci quis suscipit placerat, mi lectus convallis sem, et scelerisque urna libero nec sapien. Nam quis justo ante. Nulla placerat est nec suscipit euismod.</p>
|
||||
"""
|
||||
@truncated_description "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer malesuada commodo nunc, dictum dignissim erat aliquet quis. Morbi iaculis scelerisque magna eu dapibus. Morbi ultricies mollis arcu, vel…"
|
||||
|
||||
test "gives tags" do
|
||||
alias Mobilizon.Web.Endpoint
|
||||
%Event{} = event = insert(:event, description: @long_description)
|
||||
|
||||
%Event{} = event = insert(:event)
|
||||
tags_output = event |> Metadata.build_tags() |> Metadata.Utils.stringify_tags()
|
||||
{:ok, document} = Floki.parse_fragment(tags_output)
|
||||
assert "#{event.title} - Mobilizon" == document |> Floki.find("title") |> Floki.text()
|
||||
|
||||
# Because the description in Schema.org data is double-escaped
|
||||
a = "\n"
|
||||
b = "\\n"
|
||||
assert @truncated_description ==
|
||||
document
|
||||
|> Floki.find("meta[name=\"description\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert event
|
||||
|> Metadata.build_tags()
|
||||
|> Metadata.Utils.stringify_tags() ==
|
||||
String.trim("""
|
||||
<title>#{event.title} - Mobilizon</title><meta content="#{event.description}" name="description"><meta content="#{event.title}" property="og:title"><meta content="#{event.url}" property="og:url"><meta content="#{event.description}" property="og:description"><meta content="website" property="og:type"><link href="#{event.url}" rel="canonical"><meta content="#{event.picture.file.url}" property="og:image"><meta content="summary_large_image" property="twitter:card"><script type="application/ld+json">{"@context":"https://schema.org","@type":"Event","description":"#{String.replace(event.description, a, b)}","endDate":"#{DateTime.to_iso8601(event.ends_on)}","eventStatus":"https://schema.org/EventScheduled","image":["#{event.picture.file.url}"],"location":{"@type":"Place","address":{"@type":"PostalAddress","addressCountry":"My Country","addressLocality":"My Locality","addressRegion":"My Region","postalCode":"My Postal Code","streetAddress":"My Street Address"},"name":"#{event.physical_address.description}"},"name":"#{event.title}","organizer":{"@type":"Person","name":"#{event.organizer_actor.preferred_username}"},"performer":{"@type":"Person","name":"#{event.organizer_actor.preferred_username}"},"startDate":"#{DateTime.to_iso8601(event.begins_on)}"}</script>
|
||||
""")
|
||||
assert event.title ==
|
||||
document
|
||||
|> Floki.find("meta[property=\"og:title\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert event
|
||||
|> Map.put(:picture, nil)
|
||||
|> Metadata.build_tags()
|
||||
|> Metadata.Utils.stringify_tags() ==
|
||||
String.trim("""
|
||||
<title>#{event.title} - Mobilizon</title><meta content="#{event.description}" name="description"><meta content="#{event.title}" property="og:title"><meta content="#{event.url}" property="og:url"><meta content="#{event.description}" property="og:description"><meta content="website" property="og:type"><link href="#{event.url}" rel="canonical"><meta content="summary_large_image" property="twitter:card"><script type="application/ld+json">{"@context":"https://schema.org","@type":"Event","description":"#{String.replace(event.description, a, b)}","endDate":"#{DateTime.to_iso8601(event.ends_on)}","eventStatus":"https://schema.org/EventScheduled","image":["#{"#{Endpoint.url()}/img/mobilizon_default_card.png"}"],"location":{"@type":"Place","address":{"@type":"PostalAddress","addressCountry":"My Country","addressLocality":"My Locality","addressRegion":"My Region","postalCode":"My Postal Code","streetAddress":"My Street Address"},"name":"#{event.physical_address.description}"},"name":"#{event.title}","organizer":{"@type":"Person","name":"#{event.organizer_actor.preferred_username}"},"performer":{"@type":"Person","name":"#{event.organizer_actor.preferred_username}"},"startDate":"#{DateTime.to_iso8601(event.begins_on)}"}</script>
|
||||
""")
|
||||
assert event.url ==
|
||||
document
|
||||
|> Floki.find("meta[property=\"og:url\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert document
|
||||
|> Floki.find("meta[property=\"og:description\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd =~ @truncated_description
|
||||
|
||||
assert "website" ==
|
||||
document
|
||||
|> Floki.find("meta[property=\"og:type\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert event.url ==
|
||||
document
|
||||
|> Floki.find("link[rel=\"canonical\"]")
|
||||
|> Floki.attribute("href")
|
||||
|> hd
|
||||
|
||||
assert event.picture.file.url ==
|
||||
document
|
||||
|> Floki.find("meta[property=\"og:image\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert "summary_large_image" ==
|
||||
document
|
||||
|> Floki.find("meta[property=\"twitter:card\"]")
|
||||
|> Floki.attribute("content")
|
||||
|> hd
|
||||
|
||||
assert "event.json" |> ObjectView.render(%{event: event}) |> Jason.encode!() ==
|
||||
document
|
||||
|> Floki.find("script[type=\"application/ld+json\"]")
|
||||
|> Floki.text(js: true)
|
||||
|
||||
tags_output =
|
||||
event
|
||||
|> Map.put(:picture, nil)
|
||||
|> Metadata.build_tags()
|
||||
|> Metadata.Utils.stringify_tags()
|
||||
|
||||
{:ok, document} = Floki.parse_fragment(tags_output)
|
||||
|
||||
assert [] == Floki.find(document, "meta[property=\"og:image\"]")
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
Reference in New Issue
Block a user