Implement Credo software design suggestions

lib/mobilizon/actors/actor.ex

@@ -336,7 +336,7 @@ defmodule Mobilizon.Actors.Actor do
     |> put_change(:followers_url, build_url(username, :followers))
     |> put_change(:following_url, build_url(username, :following))
     |> put_change(:inbox_url, build_url(username, :inbox))
-    |> put_change(:shared_inbox_url, "#{Mobilizon.Web.Endpoint.url()}/inbox")
+    |> put_change(:shared_inbox_url, "#{Endpoint.url()}/inbox")
     |> put_change(:url, build_url(username, :page))
   end
 
@@ -376,10 +376,10 @@ defmodule Mobilizon.Actors.Actor do
       "keys" => Crypto.generate_rsa_2048_private_key(),
       "preferred_username" => preferred_username,
       "domain" => nil,
-      "inbox_url" => "#{Mobilizon.Web.Endpoint.url()}/inbox",
+      "inbox_url" => "#{Endpoint.url()}/inbox",
       "followers_url" => "#{url}/followers",
       "following_url" => "#{url}/following",
-      "shared_inbox_url" => "#{Mobilizon.Web.Endpoint.url()}/inbox",
+      "shared_inbox_url" => "#{Endpoint.url()}/inbox",
       "type" => :Application
     }
   end

lib/mobilizon/actors/actors.ex

@@ -16,6 +16,8 @@ defmodule Mobilizon.Actors do
 
   alias Mobilizon.Federation.ActivityPub
 
+  alias Mobilizon.Web.Upload
+
   require Logger
 
   defenum(ActorType, :actor_type, [
@@ -755,7 +757,7 @@ defmodule Mobilizon.Actors do
 
   @spec safe_remove_file(String.t(), Actor.t()) :: {:ok, Actor.t()}
   defp safe_remove_file(url, %Actor{} = actor) do
-    case Mobilizon.Web.Upload.remove(url) do
+    case Upload.remove(url) do
       {:ok, _value} ->
         {:ok, actor}
 
@@ -774,7 +776,7 @@ defmodule Mobilizon.Actors do
         with %Ecto.Changeset{changes: %{url: new_url}} <- changes[key],
              %{url: old_url} <- data |> Map.from_struct() |> Map.get(key),
              false <- new_url == old_url do
-          Mobilizon.Web.Upload.remove(old_url)
+          Upload.remove(old_url)
         end
       end
     end)

lib/mobilizon/actors/follower.ex

@@ -9,6 +9,8 @@ defmodule Mobilizon.Actors.Follower do
 
   alias Mobilizon.Actors.Actor
 
+  alias Mobilizon.Web.Endpoint
+
   @type t :: %__MODULE__{
           approved: boolean,
           url: String.t(),
@@ -65,6 +67,6 @@ defmodule Mobilizon.Actors.Follower do
 
     changeset
     |> put_change(:id, uuid)
-    |> put_change(:url, "#{Mobilizon.Web.Endpoint.url()}/follow/#{uuid}")
+    |> put_change(:url, "#{Endpoint.url()}/follow/#{uuid}")
   end
 end