Implement Credo software design suggestions
This commit is contained in:
@@ -16,6 +16,8 @@ defmodule Mobilizon.Actors do
|
||||
|
||||
alias Mobilizon.Federation.ActivityPub
|
||||
|
||||
alias Mobilizon.Web.Upload
|
||||
|
||||
require Logger
|
||||
|
||||
defenum(ActorType, :actor_type, [
|
||||
@@ -755,7 +757,7 @@ defmodule Mobilizon.Actors do
|
||||
|
||||
@spec safe_remove_file(String.t(), Actor.t()) :: {:ok, Actor.t()}
|
||||
defp safe_remove_file(url, %Actor{} = actor) do
|
||||
case Mobilizon.Web.Upload.remove(url) do
|
||||
case Upload.remove(url) do
|
||||
{:ok, _value} ->
|
||||
{:ok, actor}
|
||||
|
||||
@@ -774,7 +776,7 @@ defmodule Mobilizon.Actors do
|
||||
with %Ecto.Changeset{changes: %{url: new_url}} <- changes[key],
|
||||
%{url: old_url} <- data |> Map.from_struct() |> Map.get(key),
|
||||
false <- new_url == old_url do
|
||||
Mobilizon.Web.Upload.remove(old_url)
|
||||
Upload.remove(old_url)
|
||||
end
|
||||
end
|
||||
end)
|
||||
|
||||
Reference in New Issue
Block a user