Save remote profiles avatars & banners locally

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/web/controllers/media_proxy_controller.ex

@@ -1,50 +0,0 @@
-# Portions of this file are derived from Pleroma:
-# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
-# SPDX-License-Identifier: AGPL-3.0-only
-# Upstream: https://git.pleroma.social/pleroma/pleroma/blob/develop/lib/pleroma/web/media_proxy/controller.ex
-
-defmodule Mobilizon.Web.MediaProxyController do
-  use Mobilizon.Web, :controller
-
-  alias Plug.Conn
-
-  alias Mobilizon.Config
-
-  alias Mobilizon.Web.MediaProxy
-  alias Mobilizon.Web.ReverseProxy
-
-  @default_proxy_opts [max_body_length: 25 * 1_048_576, http: [follow_redirect: true]]
-
-  def remote(conn, %{"sig" => sig64, "url" => url64} = params) do
-    with config <- Config.get([:media_proxy], []),
-         true <- Keyword.get(config, :enabled, false),
-         {:ok, url} <- MediaProxy.decode_url(sig64, url64),
-         :ok <- filename_matches(Map.has_key?(params, "filename"), conn.request_path, url) do
-      ReverseProxy.call(conn, url, Keyword.get(config, :proxy_opts, @default_proxy_opts))
-    else
-      false ->
-        send_resp(conn, 404, Conn.Status.reason_phrase(404))
-
-      {:error, :invalid_signature} ->
-        send_resp(conn, 403, Conn.Status.reason_phrase(403))
-
-      {:wrong_filename, filename} ->
-        redirect(conn, external: MediaProxy.build_url(sig64, url64, filename))
-    end
-  end
-
-  def filename_matches(has_filename, path, url) do
-    filename =
-      url
-      |> MediaProxy.filename()
-      |> URI.decode()
-
-    path = URI.decode(path)
-
-    if has_filename && filename && Path.basename(path) != filename do
-      {:wrong_filename, filename}
-    else
-      :ok
-    end
-  end
-end

lib/web/proxy/media_proxy.ex

@@ -1,91 +0,0 @@
-# Portions of this file are derived from Pleroma:
-# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
-# SPDX-License-Identifier: AGPL-3.0-only
-# Upstream: https://git.pleroma.social/pleroma/pleroma/blob/develop/lib/pleroma/web/media_proxy/media_proxy.ex
-
-defmodule Mobilizon.Web.MediaProxy do
-  @moduledoc """
-  Handles proxifying media files
-  """
-
-  alias Mobilizon.Config
-
-  alias Mobilizon.Web.Endpoint
-
-  @base64_opts [padding: false]
-
-  def url(nil), do: nil
-
-  def url(""), do: nil
-
-  def url("/" <> _ = url), do: url
-
-  def url(url) do
-    config = Application.get_env(:mobilizon, :media_proxy, [])
-
-    if !Keyword.get(config, :enabled, false) or
-         String.starts_with?(url, Endpoint.url()) do
-      url
-    else
-      encode_url(url)
-    end
-  end
-
-  def encode_url(url) do
-    secret = Application.get_env(:mobilizon, Endpoint)[:secret_key_base]
-
-    # Must preserve `%2F` for compatibility with S3
-    # https://git.pleroma.social/pleroma/pleroma/issues/580
-    replacement = get_replacement(url, ":2F:")
-
-    # The URL is url-decoded and encoded again to ensure it is correctly encoded and not twice.
-    base64 =
-      url
-      |> String.replace("%2F", replacement)
-      |> URI.decode()
-      |> URI.encode()
-      |> String.replace(replacement, "%2F")
-      |> Base.url_encode64(@base64_opts)
-
-    sig = :crypto.hmac(:sha, secret, base64)
-    sig64 = sig |> Base.url_encode64(@base64_opts)
-
-    build_url(sig64, base64, filename(url))
-  end
-
-  def decode_url(sig, url) do
-    secret = Application.get_env(:mobilizon, Endpoint)[:secret_key_base]
-    sig = Base.url_decode64!(sig, @base64_opts)
-    local_sig = :crypto.hmac(:sha, secret, url)
-
-    if local_sig == sig do
-      {:ok, Base.url_decode64!(url, @base64_opts)}
-    else
-      {:error, :invalid_signature}
-    end
-  end
-
-  def filename(url_or_path) do
-    if path = URI.parse(url_or_path).path, do: Path.basename(path)
-  end
-
-  def build_url(sig_base64, url_base64, filename \\ nil) do
-    [
-      Config.get([:media_proxy, :base_url], Endpoint.url()),
-      "proxy",
-      sig_base64,
-      url_base64,
-      filename
-    ]
-    |> Enum.filter(fn value -> value end)
-    |> Path.join()
-  end
-
-  defp get_replacement(url, replacement) do
-    if String.contains?(url, replacement) do
-      get_replacement(url, replacement <> replacement)
-    else
-      replacement
-    end
-  end
-end

lib/web/proxy/reverse_proxy.ex

@@ -69,8 +69,6 @@ defmodule Mobilizon.Web.ReverseProxy do
 
   alias Plug.Conn
 
-  alias Mobilizon.Web.MediaProxy
-
   require Logger
 
   @type option ::
@@ -111,7 +109,7 @@ defmodule Mobilizon.Web.ReverseProxy do
     req_headers = build_req_headers(conn.req_headers, opts)
 
     opts =
-      if filename = MediaProxy.filename(url) do
+      if filename = filename(url) do
         Keyword.put_new(opts, :attachment_name, filename)
       else
         opts
@@ -388,4 +386,8 @@ defmodule Mobilizon.Web.ReverseProxy do
   defp increase_read_duration(_) do
     {:ok, :no_duration_limit, :no_duration_limit}
   end
+
+  def filename(url_or_path) do
+    if path = URI.parse(url_or_path).path, do: Path.basename(path)
+  end
 end

lib/web/router.ex

@@ -162,13 +162,6 @@ defmodule Mobilizon.Web.Router do
     post("/auth/:provider/callback", AuthController, :callback)
   end
 
-  scope "/proxy/", Mobilizon.Web do
-    pipe_through(:remote_media)
-
-    get("/:sig/:url", MediaProxyController, :remote)
-    get("/:sig/:url/:filename", MediaProxyController, :remote)
-  end
-
   if Application.fetch_env!(:mobilizon, :env) in [:dev, :e2e] do
     # If using Phoenix
     forward("/sent_emails", Bamboo.SentEmailViewerPlug)

lib/web/views/json_ld/object_view.ex

@@ -5,7 +5,7 @@ defmodule Mobilizon.Web.JsonLD.ObjectView do
   alias Mobilizon.Addresses.Address
   alias Mobilizon.Events.Event
   alias Mobilizon.Posts.Post
-  alias Mobilizon.Web.{Endpoint, MediaProxy}
+  alias Mobilizon.Web.Endpoint
   alias Mobilizon.Web.JsonLD.ObjectView
 
   def render("group.json", %{group: %Actor{} = group}) do
@@ -41,7 +41,7 @@ defmodule Mobilizon.Web.JsonLD.ObjectView do
       "image" =>
         if(event.picture,
           do: [
-            event.picture.file.url |> MediaProxy.url()
+            event.picture.file.url
           ],
           else: ["#{Endpoint.url()}/img/mobilizon_default_card.png"]
         )