Introduce group posts

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/web/views/activity_pub/actor_view.ex

@@ -1,16 +1,21 @@
 defmodule Mobilizon.Web.ActivityPub.ActorView do
   use Mobilizon.Web, :view
 
-  alias Mobilizon.Actors
+  alias Mobilizon.{Actors, Discussions, Events, Posts, Resources, Todos}
   alias Mobilizon.Actors.{Actor, Member}
-  alias Mobilizon.Resources
-  alias Mobilizon.Resources.Resource
-
+  alias Mobilizon.Discussions.Discussion
+  alias Mobilizon.Events.Event
   alias Mobilizon.Federation.ActivityPub
   alias Mobilizon.Federation.ActivityPub.{Activity, Utils}
   alias Mobilizon.Federation.ActivityStream.Convertible
+  alias Mobilizon.Posts.Post
+  alias Mobilizon.Resources.Resource
+  alias Mobilizon.Storage.Page
+  alias Mobilizon.Todos.TodoList
 
   @private_visibility_empty_collection %{elements: [], total: 0}
+  @json_ld_header Utils.make_json_ld_header()
+  @selected_member_roles ~w(creator administrator moderator member)a
 
   def render("actor.json", %{actor: actor}) do
     actor
@@ -18,145 +23,120 @@ defmodule Mobilizon.Web.ActivityPub.ActorView do
     |> Map.merge(Utils.make_json_ld_header())
   end
 
-  def render("following.json", %{actor: actor, page: page}) do
-    %{total: total, elements: following} =
-      if Actor.is_public_visibility(actor),
-        do: Actors.build_followings_for_actor(actor, page),
-        else: @private_visibility_empty_collection
+  @doc """
+  Render an actor collection
+  """
+  @spec render(String.t(), map()) :: map()
+  def render(view_name, %{actor: %Actor{} = actor} = args) do
+    is_root? = is_nil(Map.get(args, :page))
+    page = Map.get(args, :page, 1)
+    collection_name = String.trim_trailing(view_name, ".json")
+    collection_name = String.to_existing_atom(collection_name)
 
-    following
-    |> collection(actor.preferred_username, :following, page, total)
-    |> Map.merge(Utils.make_json_ld_header())
+    %{total: total, elements: elements} =
+      if can_get_collection?(collection_name, actor, Map.get(args, :actor_applicant)),
+        do: fetch_collection(collection_name, actor, page),
+        else: default_collection(collection_name, actor, page)
+
+    collection =
+      if is_root? do
+        root_collection(elements, actor, collection_name, total)
+      else
+        collection(elements, actor.preferred_username, collection_name, page, total)
+      end
+
+    Map.merge(collection, @json_ld_header)
   end
 
-  def render("following.json", %{actor: actor}) do
-    %{total: total, elements: following} =
-      if Actor.is_public_visibility(actor),
-        do: Actors.build_followings_for_actor(actor),
-        else: @private_visibility_empty_collection
-
+  @spec root_collection(Enum.t(), Actor.t(), atom(), integer()) :: map()
+  defp root_collection(
+         elements,
+         %Actor{preferred_username: preferred_username, url: actor_url},
+         collection,
+         total
+       ) do
     %{
-      "id" => Actor.build_url(actor.preferred_username, :following),
+      "id" => Actor.build_url(preferred_username, collection),
+      "attributedTo" => actor_url,
       "type" => "OrderedCollection",
       "totalItems" => total,
-      "first" => collection(following, actor.preferred_username, :following, 1, total)
+      "first" => collection(elements, preferred_username, collection, 1, total)
     }
-    |> Map.merge(Utils.make_json_ld_header())
   end
 
-  def render("followers.json", %{actor: actor, page: page}) do
-    %{total: total, elements: followers} =
-      if Actor.is_public_visibility(actor),
-        do: Actors.build_followers_for_actor(actor, page),
-        else: @private_visibility_empty_collection
-
-    followers
-    |> collection(actor.preferred_username, :followers, page, total)
-    |> Map.merge(Utils.make_json_ld_header())
+  @spec fetch_collection(atom(), Actor.t(), integer()) :: Page.t()
+  defp fetch_collection(:following, actor, page) do
+    Actors.build_followings_for_actor(actor, page)
   end
 
-  def render("followers.json", %{actor: actor}) do
-    %{total: total, elements: followers} =
-      if Actor.is_public_visibility(actor),
-        do: Actors.build_followers_for_actor(actor),
-        else: @private_visibility_empty_collection
-
-    %{
-      "id" => actor.followers_url,
-      "type" => "OrderedCollection",
-      "totalItems" => total,
-      "first" => collection(followers, actor.preferred_username, :followers, 1, total)
-    }
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:followers, actor, page) do
+    Actors.build_followers_for_actor(actor, page)
   end
 
-  def render("members.json", %{group: group, page: page, actor_applicant: actor_applicant}) do
-    %{total: total, elements: members} =
-      if Actor.is_public_visibility(group) ||
-           actor_applicant_group_member?(group, actor_applicant),
-         do: Actors.list_members_for_group(group, page),
-         else: @private_visibility_empty_collection
-
-    members
-    |> collection(group.preferred_username, :members, page, total)
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:members, actor, page) do
+    Actors.list_members_for_group(actor, @selected_member_roles, page)
   end
 
-  def render("members.json", %{group: group, actor_applicant: actor_applicant}) do
-    %{total: total, elements: members} =
-      if Actor.is_public_visibility(group) ||
-           actor_applicant_group_member?(group, actor_applicant),
-         do: Actors.list_members_for_group(group),
-         else: @private_visibility_empty_collection
-
-    %{
-      "id" => group.url,
-      "attributedTo" => group.url,
-      "type" => "OrderedCollection",
-      "totalItems" => total,
-      "first" => collection(members, group.preferred_username, :members, 1, total)
-    }
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:resources, actor, page) do
+    Resources.get_resources_for_group(actor, page)
   end
 
-  def render("resources.json", %{group: group, page: page, actor_applicant: actor_applicant}) do
-    %{total: total, elements: resources} =
-      if Actor.is_public_visibility(group) ||
-           actor_applicant_group_member?(group, actor_applicant),
-         do: Resources.get_top_level_resources_for_group(group),
-         else: @private_visibility_empty_collection
-
-    resources
-    |> collection(group.preferred_username, :resources, page, total)
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:discussions, actor, page) do
+    Discussions.find_discussions_for_actor(actor.id, page)
   end
 
-  def render("resources.json", %{group: group, actor_applicant: actor_applicant}) do
-    %{total: total, elements: resources} =
-      if Actor.is_public_visibility(group) ||
-           actor_applicant_group_member?(group, actor_applicant),
-         do: Resources.get_top_level_resources_for_group(group),
-         else: @private_visibility_empty_collection
-
-    %{
-      "id" => group.resources_url,
-      "attributedTo" => group.url,
-      "type" => "OrderedCollection",
-      "totalItems" => total,
-      "first" => collection(resources, group.preferred_username, :resources, 1, total)
-    }
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:posts, actor, page) do
+    Posts.get_posts_for_group(actor, page)
   end
 
-  def render("outbox.json", %{actor: actor, page: page}) do
-    %{total: total, elements: followers} =
-      if Actor.is_public_visibility(actor),
-        do: ActivityPub.fetch_public_activities_for_actor(actor, page),
-        else: @private_visibility_empty_collection
-
-    followers
-    |> collection(actor.preferred_username, :outbox, page, total)
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:events, actor, page) do
+    Events.list_organized_events_for_group(actor, page)
   end
 
-  def render("outbox.json", %{actor: actor}) do
-    %{total: total, elements: followers} =
-      if Actor.is_public_visibility(actor),
-        do: ActivityPub.fetch_public_activities_for_actor(actor),
-        else: @private_visibility_empty_collection
-
-    %{
-      "id" => Actor.build_url(actor.preferred_username, :outbox),
-      "type" => "OrderedCollection",
-      "totalItems" => total,
-      "first" => collection(followers, actor.preferred_username, :outbox, 1, total)
-    }
-    |> Map.merge(Utils.make_json_ld_header())
+  defp fetch_collection(:todos, actor, page) do
+    Todos.get_todo_lists_for_group(actor, page)
   end
 
+  @spec fetch_collection(atom(), Actor.t(), integer()) :: %{total: integer(), elements: Enum.t()}
+  defp fetch_collection(:outbox, actor, page) do
+    ActivityPub.fetch_public_activities_for_actor(actor, page)
+  end
+
+  defp fetch_collection(_, _, _), do: @private_visibility_empty_collection
+
+  @spec can_get_collection?(atom(), Actor.t(), Actor.t()) :: boolean()
+  # Outbox only contains public activities
+  defp can_get_collection?(collection, %Actor{visibility: visibility} = _actor, _actor_applicant)
+       when visibility in [:public, :unlisted] and collection in [:outbox, :followers, :following],
+       do: true
+
+  defp can_get_collection?(_collection_name, %Actor{} = actor, %Actor{} = actor_applicant),
+    do: actor_applicant_group_member?(actor, actor_applicant)
+
+  defp can_get_collection?(_, _, _), do: false
+
+  # Posts and events allows to browse public content
+  defp default_collection(:posts, %Actor{} = actor, page),
+    do: Posts.get_public_posts_for_group(actor, page)
+
+  defp default_collection(:events, %Actor{} = actor, page),
+    do: Events.list_public_events_for_actor(actor, page)
+
+  defp default_collection(_, _, _), do: @private_visibility_empty_collection
+
   @spec collection(list(), String.t(), atom(), integer(), integer()) :: map()
   defp collection(collection, preferred_username, endpoint, page, total)
-       when endpoint in [:followers, :following, :outbox, :members, :resources, :todos] do
+       when endpoint in [
+              :followers,
+              :following,
+              :outbox,
+              :members,
+              :resources,
+              :todos,
+              :posts,
+              :events,
+              :discussions
+            ] do
     offset = (page - 1) * 10
 
     map = %{
@@ -178,6 +158,10 @@ defmodule Mobilizon.Web.ActivityPub.ActorView do
   def item(%Actor{url: url}), do: url
   def item(%Member{} = member), do: Convertible.model_to_as(member)
   def item(%Resource{} = resource), do: Convertible.model_to_as(resource)
+  def item(%Discussion{} = discussion), do: Convertible.model_to_as(discussion)
+  def item(%Post{} = post), do: Convertible.model_to_as(post)
+  def item(%Event{} = event), do: Convertible.model_to_as(event)
+  def item(%TodoList{} = todo_list), do: Convertible.model_to_as(todo_list)
 
   defp actor_applicant_group_member?(%Actor{}, nil), do: false
 

lib/web/views/json_ld/object_view.ex

@@ -4,24 +4,30 @@ defmodule Mobilizon.Web.JsonLD.ObjectView do
   alias Mobilizon.Actors.Actor
   alias Mobilizon.Addresses.Address
   alias Mobilizon.Events.Event
-
+  alias Mobilizon.Posts.Post
   alias Mobilizon.Web.JsonLD.ObjectView
   alias Mobilizon.Web.MediaProxy
 
   def render("event.json", %{event: %Event{} = event}) do
-    # TODO: event.description is actually markdown!
+    organizer = %{
+      "@type" => if(event.organizer_actor.type == :Group, do: "Organization", else: "Person"),
+      "name" => Actor.display_name(event.organizer_actor)
+    }
 
     json_ld = %{
       "@context" => "https://schema.org",
       "@type" => "Event",
       "name" => event.title,
       "description" => event.description,
-      "performer" => %{
-        "@type" =>
-          if(event.organizer_actor.type == :Group, do: "PerformingGroup", else: "Person"),
-        "name" => Actor.display_name(event.organizer_actor)
-      },
-      "location" => render_one(event.physical_address, ObjectView, "place.json", as: :address)
+      # We assume for now performer == organizer
+      "performer" => organizer,
+      "organizer" => organizer,
+      "location" => render_one(event.physical_address, ObjectView, "place.json", as: :address),
+      "eventStatus" =>
+        if(event.status == :cancelled,
+          do: "https://schema.org/EventCancelled",
+          else: "https://schema.org/EventScheduled"
+        )
     }
 
     json_ld =
@@ -62,4 +68,18 @@ defmodule Mobilizon.Web.JsonLD.ObjectView do
   end
 
   def render("place.json", nil), do: %{}
+
+  def render("post.json", %{post: %Post{} = post}) do
+    %{
+      "@context" => "https://schema.org",
+      "@type" => "Article",
+      "name" => post.title,
+      "author" => %{
+        "@type" => "Organization",
+        "name" => Actor.display_name(post.attributed_to)
+      },
+      "datePublished" => post.publish_at,
+      "dateModified" => post.updated_at
+    }
+  end
 end

lib/web/views/page_view.ex

@@ -6,7 +6,7 @@ defmodule Mobilizon.Web.PageView do
   use Mobilizon.Web, :view
 
   alias Mobilizon.Actors.Actor
-  alias Mobilizon.Conversations.Comment
+  alias Mobilizon.Discussions.{Comment, Discussion}
   alias Mobilizon.Events.Event
   alias Mobilizon.Resources.Resource
   alias Mobilizon.Tombstone
@@ -42,6 +42,12 @@ defmodule Mobilizon.Web.PageView do
     |> Map.merge(Utils.make_json_ld_header())
   end
 
+  def render("discussion.activity-json", %{conn: %{assigns: %{object: %Discussion{} = resource}}}) do
+    resource
+    |> Convertible.model_to_as()
+    |> Map.merge(Utils.make_json_ld_header())
+  end
+
   def render("resource.activity-json", %{conn: %{assigns: %{object: %Resource{} = resource}}}) do
     resource
     |> Convertible.model_to_as()
@@ -49,12 +55,15 @@ defmodule Mobilizon.Web.PageView do
   end
 
   def render(page, %{object: object, conn: conn} = _assigns)
-      when page in ["actor.html", "event.html", "comment.html"] do
+      when page in ["actor.html", "event.html", "comment.html", "post.html"] do
     locale = get_locale(conn)
     tags = object |> Metadata.build_tags(locale)
     inject_tags(tags, locale)
   end
 
+  # Discussions are private, no need to embed metadata
+  def render("discussion.html", params), do: render("index.html", params)
+
   def render("index.html", %{conn: conn}) do
     tags = Instance.build_tags()
     inject_tags(tags, get_locale(conn))

lib/web/views/utils.ex

@@ -5,7 +5,7 @@ defmodule Mobilizon.Web.Views.Utils do
 
   alias Mobilizon.Service.Metadata.Utils, as: MetadataUtils
 
-  @spec inject_tags(List.t(), String.t()) :: {:safe, String.t()}
+  @spec inject_tags(Enum.t(), String.t()) :: {:safe, String.t()}
   def inject_tags(tags, locale \\ "en") do
     with {:ok, index_content} <- File.read(index_file_path()) do
       do_replacements(index_content, MetadataUtils.stringify_tags(tags), locale)