Introduce group posts

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

test/service/geospatial/map_quest_test.exs

@@ -1,28 +1,11 @@
 defmodule Mobilizon.Service.Geospatial.MapQuestTest do
-  use ExVCR.Mock, adapter: ExVCR.Adapter.Hackney
-
   use Mobilizon.DataCase
 
-  import Mock
+  import Mox
 
   alias Mobilizon.Addresses.Address
-  alias Mobilizon.Config
   alias Mobilizon.Service.Geospatial.MapQuest
-
-  @http_options [
-    follow_redirect: true,
-    ssl: [{:versions, [:"tlsv1.2"]}]
-  ]
-
-  setup do
-    # Config.instance_user_agent/0 makes database calls so because of ownership connection
-    # we need to define it like this instead of a constant
-    # See https://hexdocs.pm/ecto_sql/Ecto.Adapters.SQL.Sandbox.html
-    {:ok,
-     httpoison_headers: [
-       {"User-Agent", Config.instance_user_agent()}
-     ]}
-  end
+  alias Mobilizon.Service.HTTP.BaseClient.Mock
 
   describe "search address" do
     test "without API Key triggers an error" do
@@ -31,75 +14,88 @@ defmodule Mobilizon.Service.Geospatial.MapQuestTest do
       end
     end
 
-    test "produces a valid search address with options", %{httpoison_headers: httpoison_headers} do
-      with_mock HTTPoison,
-        get: fn _url, _headers, _options ->
-          {:ok,
-           %HTTPoison.Response{
-             status_code: 200,
-             body: "{\"info\": {\"statuscode\": 0}, \"results\": []}"
-           }}
-        end do
-        MapQuest.search("10 Rue Jangot",
-          limit: 5,
-          lang: "fr",
-          api_key: "toto"
-        )
-
-        assert_called(
-          HTTPoison.get(
-            "https://open.mapquestapi.com/geocoding/v1/address?key=toto&location=10%20Rue%20Jangot&maxResults=5",
-            httpoison_headers,
-            @http_options
-          )
-        )
-      end
-    end
-
     test "triggers an error with an invalid API Key" do
+      Mock
+      |> expect(:call, fn
+        %{
+          method: :get,
+          url:
+            "https://open.mapquestapi.com/geocoding/v1/address?key=secret_key&location=10%20rue%20Jangot&maxResults=10"
+        },
+        _opts ->
+          {:ok,
+           %Tesla.Env{status: 403, body: "The AppKey submitted with this request is invalid."}}
+      end)
+
       assert_raise ArgumentError, "The AppKey submitted with this request is invalid.", fn ->
         MapQuest.search("10 rue Jangot", api_key: "secret_key")
       end
     end
 
     test "returns a valid address from search" do
-      use_cassette "geospatial/map_quest/search" do
-        assert %Address{
-                 locality: "Lyon",
-                 description: "10 Rue Jangot",
-                 region: "Auvergne-Rhône-Alpes",
-                 country: "FR",
-                 postal_code: "69007",
-                 street: "10 Rue Jangot",
-                 geom: %Geo.Point{
-                   coordinates: {4.842566, 45.751714},
-                   properties: %{},
-                   srid: 4326
-                 }
-               } ==
-                 MapQuest.search("10 rue Jangot", api_key: "secret_key")
-                 |> hd
-      end
+      data =
+        File.read!("test/fixtures/geospatial/map_quest/search.json")
+        |> Jason.decode!()
+
+      Mock
+      |> expect(:call, fn
+        %{
+          method: :get,
+          url:
+            "https://open.mapquestapi.com/geocoding/v1/address?key=secret_key&location=10%20rue%20Jangot&maxResults=10"
+        },
+        _opts ->
+          {:ok, %Tesla.Env{status: 200, body: data}}
+      end)
+
+      assert %Address{
+               locality: "Lyon",
+               description: "10 Rue Jangot",
+               region: "Auvergne-Rhône-Alpes",
+               country: "FR",
+               postal_code: "69007",
+               street: "10 Rue Jangot",
+               geom: %Geo.Point{
+                 coordinates: {4.842566, 45.751714},
+                 properties: %{},
+                 srid: 4326
+               }
+             } ==
+               MapQuest.search("10 rue Jangot", api_key: "secret_key")
+               |> hd
     end
 
     test "returns a valid address from reverse geocode" do
-      use_cassette "geospatial/map_quest/geocode" do
-        assert %Address{
-                 locality: "Lyon",
-                 description: "10 Rue Jangot",
-                 region: "Auvergne-Rhône-Alpes",
-                 country: "FR",
-                 postal_code: "69007",
-                 street: "10 Rue Jangot",
-                 geom: %Geo.Point{
-                   coordinates: {4.842569, 45.751718},
-                   properties: %{},
-                   srid: 4326
-                 }
-               } ==
-                 MapQuest.geocode(4.842569, 45.751718, api_key: "secret_key")
-                 |> hd
-      end
+      data =
+        File.read!("test/fixtures/geospatial/map_quest/geocode.json")
+        |> Jason.decode!()
+
+      Mock
+      |> expect(:call, fn
+        %{
+          method: :get,
+          url:
+            "https://open.mapquestapi.com/geocoding/v1/reverse?key=secret_key&location=45.751718,4.842569&maxResults=10"
+        },
+        _opts ->
+          {:ok, %Tesla.Env{status: 200, body: data}}
+      end)
+
+      assert %Address{
+               locality: "Lyon",
+               description: "10 Rue Jangot",
+               region: "Auvergne-Rhône-Alpes",
+               country: "FR",
+               postal_code: "69007",
+               street: "10 Rue Jangot",
+               geom: %Geo.Point{
+                 coordinates: {4.842569, 45.751718},
+                 properties: %{},
+                 srid: 4326
+               }
+             } ==
+               MapQuest.geocode(4.842569, 45.751718, api_key: "secret_key")
+               |> hd
     end
   end
 end