Revert "Merge branch 'make_e2e_tests_work_again' into 'main'"

This reverts commit d84b7e3d14, reversing
changes made to 394e66683a.

src/utils/identity.ts

@@ -38,8 +38,7 @@ export async function changeIdentity(identity: IPerson): Promise<void> {
  * the current identity used
  */
 export async function initializeCurrentActor(
-  identities: IPerson[] | undefined,
-  rethrow = false
+  identities: IPerson[] | undefined
 ): Promise<void> {
   const actorId = localStorage.getItem(AUTH_USER_ACTOR_ID);
   console.debug("Initializing current actor", actorId);
@@ -63,10 +62,6 @@ export async function initializeCurrentActor(
       await changeIdentity(activeIdentity);
     }
   } catch (e) {
-    if (rethrow) {
-      throw e;
-    } else {
-      console.error("Failed to initialize current Actor", e);
-    }
+    console.error("Failed to initialize current Actor", e);
   }
 }

src/views/User/LoginView.vue

@@ -239,13 +239,7 @@ const loginAction = async (e: Event) => {
       throw new Error("Loading user's identities failed");
     }
 
-    // at some point this function was refactored to log errors rather than
-    // throwing them, which made the catch below useless. The second argument
-    // specifies that errors should be thrown instead of logged
-    await initializeCurrentActor(
-      currentUserIdentitiesResult.loggedUser.actors,
-      true
-    );
+    await initializeCurrentActor(currentUserIdentitiesResult.loggedUser.actors);
 
     // Step 3a following
     const loggedUserLocationResult = await loggedUserLocationPromise;