refactor: use Phoenix verified routes

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/service/metadata/actor.ex

@@ -2,9 +2,8 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Actors.Actor do
   alias Phoenix.HTML
   alias Phoenix.HTML.Tag
   alias Mobilizon.Actors.Actor
-  alias Mobilizon.Web.Endpoint
   alias Mobilizon.Web.JsonLD.ObjectView
-  alias Mobilizon.Web.Router.Helpers, as: Routes
+  use Mobilizon.Web, :verified_routes
 
   import Mobilizon.Service.Metadata.Utils,
     only: [process_description: 2, default_description: 1, escape_text: 1]
@@ -25,13 +24,7 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Actors.Actor do
       Tag.tag(:meta, property: "og:title", content: actor_display_name_escaped(group)),
       Tag.tag(:meta,
         property: "og:url",
-        content:
-          Endpoint
-          |> Routes.page_url(
-            :actor,
-            Actor.preferred_username_and_domain(group)
-          )
-          |> URI.decode()
+        content: ~p"/@#{Actor.preferred_username_and_domain(group)}" |> url() |> URI.decode()
       ),
       Tag.tag(:meta, property: "og:description", content: group.summary),
       Tag.tag(:meta, property: "og:type", content: "profile"),
@@ -91,20 +84,13 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Actors.Actor do
           rel: "alternate",
           type: "application/atom+xml",
           title: gettext("%{name}'s feed", name: actor_display_name_escaped(group)) |> HTML.raw(),
-          href:
-            Routes.feed_url(Endpoint, :actor, Actor.preferred_username_and_domain(group), :atom)
+          href: url(~p"/@#{Actor.preferred_username_and_domain(group)}/feed/atom")
         ),
         Tag.tag(:link,
           rel: "alternate",
           type: "text/calendar",
           title: gettext("%{name}'s feed", name: actor_display_name_escaped(group)) |> HTML.raw(),
-          href:
-            Routes.feed_url(
-              Endpoint,
-              :actor,
-              Actor.preferred_username_and_domain(group),
-              :ics
-            )
+          href: url(~p"/@#{Actor.preferred_username_and_domain(group)}/feed/ics")
         ),
         Tag.tag(:link,
           rel: "alternate",

lib/service/metadata/event.ex

@@ -6,7 +6,7 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Events.Event do
   alias Mobilizon.Events.{Event, EventOptions}
   alias Mobilizon.Web.Endpoint
   alias Mobilizon.Web.JsonLD.ObjectView
-  alias Mobilizon.Web.Router.Helpers, as: Routes
+  use Mobilizon.Web, :verified_routes
 
   import Mobilizon.Service.Metadata.Utils,
     only: [
@@ -56,11 +56,8 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Events.Event do
                 "position" => 1,
                 "name" => event.attributed_to |> Actor.display_name() |> escape_text(),
                 "item" =>
-                  Endpoint
-                  |> Routes.page_url(
-                    :actor,
-                    Actor.preferred_username_and_domain(event.attributed_to)
-                  )
+                  ~p"/@#{Actor.preferred_username_and_domain(event.attributed_to)}"
+                  |> url()
                   |> URI.decode()
               },
               %{

lib/service/metadata/instance.ex

@@ -9,7 +9,7 @@ defmodule Mobilizon.Service.Metadata.Instance do
   alias Mobilizon.Config
   alias Mobilizon.Service.Metadata.Utils
   alias Mobilizon.Web.Endpoint
-  alias Mobilizon.Web.Router.Helpers, as: Routes
+  use Mobilizon.Web, :verified_routes
   import Mobilizon.Web.Gettext
 
   @doc """
@@ -58,13 +58,13 @@ defmodule Mobilizon.Service.Metadata.Instance do
         rel: "alternate",
         type: "application/atom+xml",
         title: gettext("%{name}'s feed", name: Config.instance_name()) |> HTML.raw(),
-        href: Routes.feed_url(Endpoint, :instance, :atom)
+        href: url(~p"/feed/instance/atom")
       ),
       Tag.tag(:link,
         rel: "alternate",
         type: "text/calendar",
         title: gettext("%{name}'s feed", name: Config.instance_name()) |> HTML.raw(),
-        href: Routes.feed_url(Endpoint, :instance, :ics)
+        href: url(~p"/feed/instance/ics")
       )
     ]
   end

lib/service/metadata/post.ex

@@ -4,9 +4,8 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Posts.Post do
   alias Mobilizon.Actors.Actor
   alias Mobilizon.Medias.{File, Media}
   alias Mobilizon.Posts.Post
-  alias Mobilizon.Web.Endpoint
+  use Mobilizon.Web, :verified_routes
   alias Mobilizon.Web.JsonLD.ObjectView
-  alias Mobilizon.Web.Router.Helpers, as: Routes
 
   import Mobilizon.Service.Metadata.Utils,
     only: [process_description: 2, strip_tags: 1, escape_text: 1]
@@ -35,11 +34,8 @@ defimpl Mobilizon.Service.Metadata, for: Mobilizon.Posts.Post do
           "position" => 1,
           "name" => post.attributed_to |> Actor.display_name() |> escape_text,
           "item" =>
-            Endpoint
-            |> Routes.page_url(
-              :actor,
-              Actor.preferred_username_and_domain(post.attributed_to)
-            )
+            ~p"/@#{Actor.preferred_username_and_domain(post.attributed_to)}"
+            |> url()
             |> URI.decode()
         },
         %{