refactor: use Phoenix verified routes

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/web/templates/email/activity/_comment_activity_item.html.heex

@@ -3,9 +3,7 @@
     <%= dgettext("activity", "%{profile} mentionned you in a comment under event %{event}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       event:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :event,
-        @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
     })
@@ -14,9 +12,7 @@
     <%= dgettext("activity", "%{profile} has posted an announcement under event %{event}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       event:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :event,
-        @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
     })
@@ -26,9 +22,7 @@
       <%= dgettext("activity", "%{profile} has posted a new reply under your event %{event}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         event:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :event,
-          @activity.subject_params["event_uuid"]) |> URI.decode()}#comment-#{@activity.subject_params["comment_reply_to_uuid"]}-#{@activity.subject_params["comment_uuid"]}\">
+          "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}#comment-#{@activity.subject_params["comment_reply_to_uuid"]}-#{@activity.subject_params["comment_uuid"]}\">
                                 #{escape_html(@activity.subject_params["event_title"])}
                             </a>"
       })
@@ -40,9 +34,7 @@
         %{
           profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
           event:
-            "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-            :event,
-            @activity.subject_params["event_uuid"]) |> URI.decode()}#comment-#{@activity.subject_params["comment_uuid"]}\">
+            "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}#comment-#{@activity.subject_params["comment_uuid"]}\">
                                 #{escape_html(@activity.subject_params["event_title"])}
                             </a>"
         }

lib/web/templates/email/activity/_comment_activity_item.text.eex

@@ -4,22 +4,22 @@
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% :participation_event_comment -> %><%= dgettext("activity", "%{profile} has posted an announcement under event %{event}.",
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% :participation_event_comment -> %><%= dgettext("activity", "%{profile} has posted an announcement under event %{event}.",
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% :event_new_comment -> %><%= if @activity.subject_params["comment_reply_to"] do %><%=dgettext("activity", "%{profile} has posted a new reply under your event %{event}.",
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% :event_new_comment -> %><%= if @activity.subject_params["comment_reply_to"] do %><%=dgettext("activity", "%{profile} has posted a new reply under your event %{event}.",
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= "#{Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode()}#comment-#{@activity.subject_params["comment_reply_to_uuid"]}-#{@activity.subject_params["comment_uuid"]}" %><% else %><%= dgettext("activity", "%{profile} has posted a new comment under your event %{event}.", 
+<%= "#{url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode()}#comment-#{@activity.subject_params["comment_reply_to_uuid"]}-#{@activity.subject_params["comment_uuid"]}" %><% else %><%= dgettext("activity", "%{profile} has posted a new comment under your event %{event}.", 
 %{
     profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
     event: @activity.subject_params["event_title"]
 }
 ) %>
-<%= "#{Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode()}#comment-#{@activity.subject_params["comment_uuid"]}"%><% end %><% end %>
+<%= "#{url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode()}#comment-#{@activity.subject_params["comment_uuid"]}"%><% end %><% end %>

lib/web/templates/email/activity/_conversation_activity_item.html.heex

@@ -3,18 +3,14 @@
     <%= dgettext("activity", "%{profile} mentionned you in a %{conversation}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       conversation:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :conversation,
-        @activity.subject_params["conversation_participant_id"]) |> URI.decode()}\">conversation</a>"
+        "<a href=\"#{~p"/conversations/#{@activity.subject_params["conversation_participant_id"]}" |> url() |> URI.decode()}\">conversation</a>"
     })
     |> raw %>
   <% :conversation_replied -> %>
     <%= dgettext("activity", "%{profile} replied you in a %{conversation}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       conversation:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :conversation,
-        @activity.subject_params["conversation_participant_id"]) |> URI.decode()}\">conversation</a>"
+        "<a href=\"#{~p"/conversations/#{@activity.subject_params["conversation_participant_id"]}" |> url() |> URI.decode()}\">conversation</a>"
     })
     |> raw %>
 <% end %>

lib/web/templates/email/activity/_conversation_activity_item.text.eex

@@ -3,9 +3,9 @@
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :conversation, @activity.subject_params["conversation_participant_id"]) |> URI.decode() %><% :conversation_replied -> %><%= dgettext("activity", "%{profile} replied you in a conversation.",
+<%= url(~p"/conversations/#{@activity.subject_params["conversation_participant_id"]}") |> URI.decode() %><% :conversation_replied -> %><%= dgettext("activity", "%{profile} replied you in a conversation.",
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :conversation, @activity.subject_params["conversation_participant_id"]) |> URI.decode() %><% end %>
+<%= url(~p"/conversations/#{@activity.subject_params["conversation_participant_id"]}") |> URI.decode() %><% end %>

lib/web/templates/email/activity/_discussion_activity_item.html.heex

@@ -3,7 +3,7 @@
     <%= dgettext("activity", "%{profile} created the discussion %{discussion}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       discussion:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["discussion_title"])}</a>"
     })
     |> raw %>
@@ -11,7 +11,7 @@
     <%= dgettext("activity", "%{profile} replied to the discussion %{discussion}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       discussion:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["discussion_title"])}</a>"
     })
     |> raw %>
@@ -19,7 +19,7 @@
     <%= dgettext("activity", "%{profile} renamed the discussion %{discussion}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       discussion:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["discussion_title"])}</a>"
     })
     |> raw %>
@@ -27,7 +27,7 @@
     <%= dgettext("activity", "%{profile} archived the discussion %{discussion}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       discussion:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["discussion_title"])}</a>"
     })
     |> raw %>

lib/web/templates/email/activity/_discussion_activity_item.text.eex

@@ -4,25 +4,25 @@
         discussion: @activity.subject_params["discussion_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode() %><% :discussion_replied -> %><%= dgettext("activity", "%{profile} replied to the discussion %{discussion}.", 
+<%= ~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode() %><% :discussion_replied -> %><%= dgettext("activity", "%{profile} replied to the discussion %{discussion}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         discussion: @activity.subject_params["discussion_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode() %><% :discussion_renamed -> %><%= dgettext("activity", "%{profile} renamed the discussion %{discussion}.", 
+<%= ~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode() %><% :discussion_renamed -> %><%= dgettext("activity", "%{profile} renamed the discussion %{discussion}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         discussion: @activity.subject_params["discussion_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode() %><% :discussion_archived -> %><%= dgettext("activity", "%{profile} archived the discussion %{discussion}.", 
+<%= ~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode() %><% :discussion_archived -> %><%= dgettext("activity", "%{profile} archived the discussion %{discussion}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         discussion: @activity.subject_params["discussion_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :discussion, Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group), @activity.subject_params["discussion_slug"]) |> URI.decode() %><% :discussion_deleted -> %><%= dgettext("activity", "%{profile} deleted the discussion %{discussion}.", 
+<%= ~p"/#{Mobilizon.Actors.Actor.preferred_username_and_domain(@activity.group)}/c/#{@activity.subject_params["discussion_slug"]}" |> url() |> URI.decode() %><% :discussion_deleted -> %><%= dgettext("activity", "%{profile} deleted the discussion %{discussion}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         discussion: @activity.subject_params["discussion_title"]

lib/web/templates/email/activity/_event_activity_item.html.heex

@@ -3,9 +3,7 @@
     <%= dgettext("activity", "The event %{event} was created by %{profile}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       event:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :event,
-        @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
     })
@@ -14,9 +12,7 @@
     <%= dgettext("activity", "The event %{event} was updated by %{profile}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       event:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :event,
-        @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
     })
@@ -32,9 +28,7 @@
       <%= dgettext("activity", "%{profile} replied to a comment on the event %{event}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         event:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :event,
-          @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
       })
@@ -43,9 +37,7 @@
       <%= dgettext("activity", "%{profile} posted a comment on the event %{event}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         event:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :event,
-          @activity.subject_params["event_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["event_title"])}
                         </a>"
       })
@@ -55,9 +47,7 @@
     <%= dgettext("activity", "%{profile} joined your event %{event}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       event:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :event,
-        @activity.subject_params["event_uuid"]) |> URI.decode()}\">#{escape_html(@activity.subject_params["event_title"])}</a>"
+        "<a href=\"#{~p"/events/#{@activity.subject_params["event_uuid"]}" |> url() |> URI.decode()}\">#{escape_html(@activity.subject_params["event_title"])}</a>"
     })
     |> raw %>
 <% end %>

lib/web/templates/email/activity/_event_activity_item.text.eex

@@ -4,13 +4,13 @@
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% :event_updated -> %><%= dgettext("activity", "The event %{event} was updated by %{profile}.", 
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% :event_updated -> %><%= dgettext("activity", "The event %{event} was updated by %{profile}.", 
     %{
         profile: display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% :event_deleted -> %><%= dgettext("activity", "The event %{event} was deleted by %{profile}.", 
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% :event_deleted -> %><%= dgettext("activity", "The event %{event} was deleted by %{profile}.", 
     %{
         profile: display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
@@ -22,16 +22,16 @@
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} posted a comment on the event %{event}.", 
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} posted a comment on the event %{event}.", 
     %{
         profile: display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% end %><% :event_new_participation -> %><%= dgettext("activity", "%{profile} joined your event %{event}.",
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% end %><% :event_new_participation -> %><%= dgettext("activity", "%{profile} joined your event %{event}.",
     %{
         profile: display_name_and_username(@activity.author),
         event: @activity.subject_params["event_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :event, @activity.subject_params["event_uuid"]) |> URI.decode() %><% end %>
+<%= url(~p"/events/#{@activity.subject_params["event_uuid"]}") |> URI.decode() %><% end %>

lib/web/templates/email/activity/_group_activity_item.html.heex

@@ -3,9 +3,7 @@
     <%= dgettext("activity", "%{profile} created the group %{group}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       group:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :actor,
-        @activity.subject_params["group_federated_username"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/@#{@activity.subject_params["group_federated_username"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["group_name"])}
                         </a>"
     })
@@ -14,9 +12,7 @@
     <%= dgettext("activity", "%{profile} updated the group %{group}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       group:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :actor,
-        @activity.subject_params["group_federated_username"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/@#{@activity.subject_params["group_federated_username"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["group_name"])}
                         </a>"
     })

lib/web/templates/email/activity/_group_activity_item.text.eex

@@ -4,10 +4,10 @@
         group: @activity.subject_params["group_name"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :actor, @activity.subject_params["group_federated_username"]) |> URI.decode() %><% :group_updated -> %><%= dgettext("activity", "%{profile} updated the group %{group}.", 
+<%= ~p"/@#{@activity.subject_params["group_federated_username"]}" |> url() |> URI.decode() %><% :group_updated -> %><%= dgettext("activity", "%{profile} updated the group %{group}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         group: @activity.subject_params["group_name"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :actor, @activity.subject_params["group_federated_username"]) |> URI.decode() %><% end %>
+<%= ~p"/@#{@activity.subject_params["group_federated_username"]}" |> url() |> URI.decode() %><% end %>

lib/web/templates/email/activity/_post_activity_item.html.heex

@@ -3,9 +3,7 @@
     <%= dgettext("activity", "The post %{post} was created by %{profile}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       post:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :post,
-        @activity.subject_params["post_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/p/#{@activity.subject_params["post_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["post_title"])}
                         </a>"
     })
@@ -14,9 +12,7 @@
     <%= dgettext("activity", "The post %{post} was updated by %{profile}.", %{
       profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
       post:
-        "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-        :post,
-        @activity.subject_params["post_slug"]) |> URI.decode()}\">
+        "<a href=\"#{~p"/p/#{@activity.subject_params["post_slug"]}" |> url() |> URI.decode()}\">
                             #{escape_html(@activity.subject_params["post_title"])}
                         </a>"
     })

lib/web/templates/email/activity/_post_activity_item.text.eex

@@ -4,13 +4,13 @@
         post: @activity.subject_params["post_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :post, @activity.subject_params["post_slug"]) |> URI.decode() %><% :post_updated -> %><%= dgettext("activity", "The post %{post} was updated by %{profile}.", 
+<%= url(~p"/p/#{@activity.subject_params["post_slug"]}") |> URI.decode() %><% :post_updated -> %><%= dgettext("activity", "The post %{post} was updated by %{profile}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         post: @activity.subject_params["post_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :post, @activity.subject_params["post_slug"]) |> URI.decode() %><% :post_deleted -> %><%= dgettext("activity", "The post %{post} was deleted by %{profile}.", 
+<%= url(~p"/p/#{@activity.subject_params["post_slug"]}") |> URI.decode() %><% :post_deleted -> %><%= dgettext("activity", "The post %{post} was deleted by %{profile}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         post: @activity.subject_params["post_title"]

lib/web/templates/email/activity/_resource_activity_item.html.heex

@@ -4,9 +4,7 @@
       <%= dgettext("activity", "%{profile} created the folder %{resource}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         resource:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :resource,
-          @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>"
       })
@@ -15,9 +13,7 @@
       <%= dgettext("activity", "%{profile} created the resource %{resource}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         resource:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :resource,
-          @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>"
       })
@@ -31,9 +27,7 @@
         %{
           profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
           resource:
-            "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-            :resource,
-            @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+            "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>",
           old_resource_title:
@@ -48,9 +42,7 @@
         %{
           profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
           resource:
-            "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-            :resource,
-            @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+            "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>",
           old_resource_title:
@@ -64,9 +56,7 @@
       <%= dgettext("activity", "%{profile} moved the folder %{resource}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         resource:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :resource,
-          @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>"
       })
@@ -75,9 +65,7 @@
       <%= dgettext("activity", "%{profile} moved the resource %{resource}.", %{
         profile: "<b>#{escaped_display_name_and_username(@activity.author)}</b>",
         resource:
-          "<a href=\"#{Routes.page_url(Mobilizon.Web.Endpoint,
-          :resource,
-          @activity.subject_params["resource_uuid"]) |> URI.decode()}\">
+          "<a href=\"#{~p"/resource/#{@activity.subject_params["resource_uuid"]}" |> url() |> URI.decode()}\">
                                 #{escape_html(@activity.subject_params["resource_title"])}
                             </a>"
       })

lib/web/templates/email/activity/_resource_activity_item.text.eex

@@ -5,39 +5,39 @@
         resource: @activity.subject_params["resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} created the resource %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} created the resource %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% end %><% :resource_renamed -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} renamed the folder from %{old_resource_title} to %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% end %><% :resource_renamed -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} renamed the folder from %{old_resource_title} to %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"],
         old_resource_title: @activity.subject_params["old_resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} renamed the resource from %{old_resource_title} to %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} renamed the resource from %{old_resource_title} to %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"],
         old_resource_title: @activity.subject_params["old_resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% end %><% :resource_moved -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} moved the folder %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% end %><% :resource_moved -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} moved the folder %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} moved the resource %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% else %><%= dgettext("activity", "%{profile} moved the resource %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"]
     }
 ) %>
-<%= Routes.page_url(Mobilizon.Web.Endpoint, :resource, @activity.subject_params["resource_uuid"]) |> URI.decode() %><% end %><% :resource_deleted -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} deleted the folder %{resource}.", 
+<%= url(~p"/resource/#{@activity.subject_params["resource_uuid"]}") |> URI.decode() %><% end %><% :resource_deleted -> %><%= if @activity.subject_params["is_folder"] do %><%= dgettext("activity", "%{profile} deleted the folder %{resource}.", 
     %{
         profile: Mobilizon.Actors.Actor.display_name_and_username(@activity.author),
         resource: @activity.subject_params["resource_title"]