Improve handling of media file deletion

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

test/federation/activity_pub/transmogrifier/comments_test.exs

@@ -215,7 +215,7 @@ defmodule Mobilizon.Federation.ActivityPub.Transmogrifier.CommentsTest do
 
       assert capture_log([level: :warn], fn ->
                {:ok, _returned_activity, _entity} = Transmogrifier.handle_incoming(data)
-             end) =~ "[warn] Parent object is something we don't handle"
+             end) =~ "[warning] Parent object is something we don't handle"
     end
 
     test "it ignores incoming private notes" do

test/mobilizon/media/media_test.exs

@@ -4,6 +4,7 @@ defmodule Mobilizon.MediaTest do
   import Mobilizon.Factory
 
   alias Mobilizon.{Config, Medias}
+  alias Mobilizon.Medias.Media
 
   alias Mobilizon.Web.Upload.Uploader
 
@@ -29,8 +30,16 @@ defmodule Mobilizon.MediaTest do
 
       assert media.file.name == "something old"
     end
+  end
 
-    test "delete_media/1 deletes the media" do
+  describe "delete_media/1" do
+    setup do
+      File.rm_rf!(Config.get!([Uploader.Local, :uploads]))
+      File.mkdir(Config.get!([Uploader.Local, :uploads]))
+      :ok
+    end
+
+    test "deletes the media" do
       media = insert(:media)
 
       %URI{path: "/media/" <> path} = URI.parse(media.file.url)
@@ -48,5 +57,61 @@ defmodule Mobilizon.MediaTest do
                  "/" <> path
              )
     end
+
+    test "doesn't delete the media if two media entities are using the same URL" do
+      Config.put([Mobilizon.Web.Upload, :filters], [
+        Mobilizon.Web.Upload.Filter.Dedupe
+      ])
+
+      media1 = insert(:media)
+      media2 = insert(:media)
+
+      assert media1.file.url == media2.file.url
+
+      %URI{path: "/media/" <> path} = URI.parse(media1.file.url)
+
+      assert File.exists?(
+               Config.get!([Uploader.Local, :uploads]) <>
+                 "/" <> path
+             )
+
+      assert {:ok, %Media{}} = Medias.delete_media(media1)
+      assert_raise Ecto.NoResultsError, fn -> Medias.get_media!(media1.id) end
+
+      assert File.exists?(
+               Config.get!([Uploader.Local, :uploads]) <>
+                 "/" <> path
+             )
+
+      Config.put([Mobilizon.Web.Upload, :filters], [])
+    end
+
+    test "doesn't delete the media if the same file is being used in a profile" do
+      Config.put([Mobilizon.Web.Upload, :filters], [
+        Mobilizon.Web.Upload.Filter.Dedupe
+      ])
+
+      actor = insert(:actor)
+      media = insert(:media)
+
+      assert media.file.url == actor.avatar.url
+
+      %URI{path: "/media/" <> path} = URI.parse(media.file.url)
+
+      assert File.exists?(
+               Config.get!([Uploader.Local, :uploads]) <>
+                 "/" <> path
+             )
+
+      assert {:ok, %Media{}} = Medias.delete_media(media)
+      assert_raise Ecto.NoResultsError, fn -> Medias.get_media!(media.id) end
+
+      assert File.exists?(
+               Config.get!([Uploader.Local, :uploads]) <>
+                 "/" <> path
+             )
+
+      Config.put([Mobilizon.Web.Upload, :filters], [])
+    end
   end
 end