[WIP] Test transmogrifier

Introduce MobilizonWeb.API namespace

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Format

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

WIP

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

remove unneeded code

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Fix tests

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Fix warnings

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/mobilizon/actors/actor.ex

@@ -167,6 +167,7 @@ defmodule Mobilizon.Actors.Actor do
     ])
     |> build_urls(:Group)
     |> put_change(:domain, nil)
+    |> put_change(:keys, Actors.create_keys())
     |> put_change(:type, :Group)
     |> validate_required([:url, :outbox_url, :inbox_url, :type, :preferred_username])
     |> unique_constraint(:preferred_username, name: :actors_preferred_username_domain_type_index)
@@ -292,7 +293,7 @@ defmodule Mobilizon.Actors.Actor do
          {:already_following, false} <- {:already_following, following?(follower, followed)} do
       do_follow(follower, followed, approved)
     else
-      {:already_following, _} ->
+      {:already_following, %Follower{}} ->
         {:error,
          "Could not follow actor: you are already following #{followed.preferred_username}"}
 
@@ -301,6 +302,17 @@ defmodule Mobilizon.Actors.Actor do
     end
   end
 
+  @spec unfollow(struct(), struct()) :: {:ok, Follower.t()} | {:error, Ecto.Changeset.t()}
+  def unfollow(%Actor{} = followed, %Actor{} = follower) do
+    with {:already_following, %Follower{} = follow} <-
+           {:already_following, following?(follower, followed)} do
+      Actors.delete_follower(follow)
+    else
+      {:already_following, false} ->
+        {:error, "Could not unfollow actor: you are not following #{followed.preferred_username}"}
+    end
+  end
+
   defp do_follow(%Actor{} = follower, %Actor{} = followed, approved) do
     Actors.create_follower(%{
       "actor_id" => follower.id,
@@ -311,12 +323,13 @@ defmodule Mobilizon.Actors.Actor do
 
   @spec following?(struct(), struct()) :: boolean()
   def following?(
-        %Actor{id: follower_actor_id} = _follower_actor,
-        %Actor{followers: followers} = _followed
+        %Actor{} = follower_actor,
+        %Actor{} = followed_actor
       ) do
-    followers
-    |> Enum.map(& &1.actor_id)
-    |> Enum.member?(follower_actor_id)
+    case Actors.get_follower(followed_actor, follower_actor) do
+      nil -> false
+      %Follower{} = follow -> follow
+    end
   end
 
   @spec actor_acct_from_actor(struct()) :: String.t()

lib/mobilizon/actors/actors.ex

@@ -162,16 +162,41 @@ defmodule Mobilizon.Actors do
     )
   end
 
-  def get_group_by_name(name) do
-    case String.split(name, "@") do
-      [name] ->
-        Repo.get_by(Actor, preferred_username: name, type: :Group)
+  @doc """
+  Get a group by it's title
+  """
+  @spec get_group_by_title(String.t()) :: Actor.t() | nil
+  def get_group_by_title(title) do
+    case String.split(title, "@") do
+      [title] ->
+        get_local_group_by_title(title)
 
-      [name, domain] ->
-        Repo.get_by(Actor, preferred_username: name, domain: domain, type: :Group)
+      [title, domain] ->
+        Repo.one(
+          from(a in Actor,
+            where: a.preferred_username == ^title and a.type == "Group" and a.domain == ^domain
+          )
+        )
     end
   end
 
+  @doc """
+  Get a local group by it's title
+  """
+  @spec get_local_group_by_title(String.t()) :: Actor.t() | nil
+  def get_local_group_by_title(title) do
+    title
+    |> do_get_local_group_by_title
+    |> Repo.one()
+  end
+
+  @spec do_get_local_group_by_title(String.t()) :: Ecto.Query.t()
+  defp do_get_local_group_by_title(title) do
+    from(a in Actor,
+      where: a.preferred_username == ^title and a.type == "Group" and is_nil(a.domain)
+    )
+  end
+
   @doc """
   Creates a group.
 
@@ -185,8 +210,6 @@ defmodule Mobilizon.Actors do
 
   """
   def create_group(attrs \\ %{}) do
-    attrs = Map.put(attrs, :keys, create_keys())
-
     %Actor{}
     |> Actor.group_creation(attrs)
     |> Repo.insert()
@@ -218,10 +241,11 @@ defmodule Mobilizon.Actors do
             keys: data.keys,
             avatar_url: data.avatar_url,
             banner_url: data.banner_url,
-            name: data.name
+            name: data.name,
+            summary: data.summary
           ]
         ],
-        conflict_target: [:preferred_username, :domain, :type]
+        conflict_target: [:url]
       )
 
     if preload, do: {:ok, Repo.preload(actor, [:followers])}, else: {:ok, actor}
@@ -516,9 +540,11 @@ defmodule Mobilizon.Actors do
     end
   end
 
-  # Create a new RSA key
+  @doc """
+  Create a new RSA key
+  """
   @spec create_keys() :: String.t()
-  defp create_keys() do
+  def create_keys() do
     key = :public_key.generate_key({:rsa, 2048, 65_537})
     entry = :public_key.pem_entry_encode(:RSAPrivateKey, key)
     [entry] |> :public_key.pem_encode() |> String.trim_trailing()
@@ -958,6 +984,13 @@ defmodule Mobilizon.Actors do
     |> Repo.preload([:actor, :target_actor])
   end
 
+  @spec get_follower(Actor.t(), Actor.t()) :: Follower.t()
+  def get_follower(%Actor{id: followed_id}, %Actor{id: follower_id}) do
+    Repo.one(
+      from(f in Follower, where: f.target_actor_id == ^followed_id and f.actor_id == ^follower_id)
+    )
+  end
+
   @doc """
   Creates a follower.
 
@@ -1013,6 +1046,24 @@ defmodule Mobilizon.Actors do
     Repo.delete(follower)
   end
 
+  @doc """
+  Delete a follower by followed and follower actors
+
+  ## Examples
+
+      iex> delete_follower(%Actor{}, %Actor{})
+      {:ok, %Mobilizon.Actors.Follower{}}
+
+      iex> delete_follower(%Actor{}, %Actor{})
+      {:error, %Ecto.Changeset{}}
+
+  """
+  @spec delete_follower(Actor.t(), Actor.t()) ::
+          {:ok, Follower.t()} | {:error, Ecto.Changeset.t()}
+  def delete_follower(%Actor{} = followed, %Actor{} = follower) do
+    get_follower(followed, follower) |> Repo.delete()
+  end
+
   @doc """
   Returns an `%Ecto.Changeset{}` for tracking follower changes.
 

lib/mobilizon/actors/follower.ex

@@ -21,4 +21,8 @@ defmodule Mobilizon.Actors.Follower do
     |> validate_required([:score, :approved, :target_actor_id, :actor_id])
     |> unique_constraint(:target_actor_id, name: :followers_actor_target_actor_unique_index)
   end
+
+  def url(%Follower{id: id}) do
+    "#{MobilizonWeb.Endpoint.url()}/follow/#{id}/activity"
+  end
 end