Fix credo style reports following it's update

Mainly transform `with` into `case`

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/service/geospatial/addok.ex

@@ -23,7 +23,7 @@ defmodule Mobilizon.Service.Geospatial.Addok do
     with {:ok, %HTTPoison.Response{status_code: 200, body: body}} <-
            HTTPoison.get(url),
          {:ok, %{"features" => features}} <- Poison.decode(body) do
-      processData(features)
+      process_data(features)
     end
   end
 
@@ -39,7 +39,7 @@ defmodule Mobilizon.Service.Geospatial.Addok do
     with {:ok, %HTTPoison.Response{status_code: 200, body: body}} <-
            HTTPoison.get(url),
          {:ok, %{"features" => features}} <- Poison.decode(body) do
-      processData(features)
+      process_data(features)
     end
   end
 
@@ -59,23 +59,23 @@ defmodule Mobilizon.Service.Geospatial.Addok do
     end
   end
 
-  defp processData(features) do
+  defp process_data(features) do
     features
     |> Enum.map(fn %{"geometry" => geometry, "properties" => properties} ->
       %Address{
         country: Map.get(properties, "country"),
         locality: Map.get(properties, "city"),
         region: Map.get(properties, "state"),
-        description: Map.get(properties, "name") || streetAddress(properties),
+        description: Map.get(properties, "name") || street_address(properties),
         floor: Map.get(properties, "floor"),
         geom: Map.get(geometry, "coordinates") |> Provider.coordinates(),
         postal_code: Map.get(properties, "postcode"),
-        street: properties |> streetAddress()
+        street: properties |> street_address()
       }
     end)
   end
 
-  defp streetAddress(properties) do
+  defp street_address(properties) do
     if Map.has_key?(properties, "housenumber") do
       Map.get(properties, "housenumber") <> " " <> Map.get(properties, "street")
     else

lib/service/geospatial/map_quest.ex

@@ -39,7 +39,7 @@ defmodule Mobilizon.Service.Geospatial.MapQuest do
              },#{lon}&maxResults=#{limit}"
            ),
          {:ok, %{"results" => results, "info" => %{"statuscode" => 0}}} <- Poison.decode(body) do
-      results |> Enum.map(&processData/1)
+      results |> Enum.map(&process_data/1)
     else
       {:ok, %HTTPoison.Response{status_code: 403, body: err}} ->
         raise(ArgumentError, message: err)
@@ -71,14 +71,14 @@ defmodule Mobilizon.Service.Geospatial.MapQuest do
     with {:ok, %HTTPoison.Response{status_code: 200, body: body}} <-
            HTTPoison.get(url),
          {:ok, %{"results" => results, "info" => %{"statuscode" => 0}}} <- Poison.decode(body) do
-      results |> Enum.map(&processData/1)
+      results |> Enum.map(&process_data/1)
     else
       {:ok, %HTTPoison.Response{status_code: 403, body: err}} ->
         raise(ArgumentError, message: err)
     end
   end
 
-  defp processData(
+  defp process_data(
          %{
            "locations" => addresses,
            "providedLocation" => %{"latLng" => %{"lat" => lat, "lng" => lng}}
@@ -86,22 +86,22 @@ defmodule Mobilizon.Service.Geospatial.MapQuest do
        ) do
     case addresses do
       [] -> nil
-      addresses -> addresses |> hd |> produceAddress(lat, lng)
+      addresses -> addresses |> hd |> produce_address(lat, lng)
     end
   end
 
-  defp processData(%{"locations" => addresses}) do
+  defp process_data(%{"locations" => addresses}) do
     case addresses do
       [] -> nil
-      addresses -> addresses |> hd |> produceAddress()
+      addresses -> addresses |> hd |> produce_address()
     end
   end
 
-  defp produceAddress(%{"latLng" => %{"lat" => lat, "lng" => lng}} = address) do
-    produceAddress(address, lat, lng)
+  defp produce_address(%{"latLng" => %{"lat" => lat, "lng" => lng}} = address) do
+    produce_address(address, lat, lng)
   end
 
-  defp produceAddress(address, lat, lng) do
+  defp produce_address(address, lat, lng) do
     %Address{
       country: Map.get(address, "adminArea1"),
       locality: Map.get(address, "adminArea5"),

lib/service/geospatial/photon.ex

@@ -24,7 +24,7 @@ defmodule Mobilizon.Service.Geospatial.Photon do
     with {:ok, %HTTPoison.Response{status_code: 200, body: body}} <-
            HTTPoison.get(url),
          {:ok, %{"features" => features}} <- Poison.decode(body) do
-      processData(features)
+      process_data(features)
     end
   end
 
@@ -40,7 +40,7 @@ defmodule Mobilizon.Service.Geospatial.Photon do
     with {:ok, %HTTPoison.Response{status_code: 200, body: body}} <-
            HTTPoison.get(url),
          {:ok, %{"features" => features}} <- Poison.decode(body) do
-      processData(features)
+      process_data(features)
     end
   end
 
@@ -61,23 +61,23 @@ defmodule Mobilizon.Service.Geospatial.Photon do
     end
   end
 
-  defp processData(features) do
+  defp process_data(features) do
     features
     |> Enum.map(fn %{"geometry" => geometry, "properties" => properties} ->
       %Address{
         country: Map.get(properties, "country"),
         locality: Map.get(properties, "city"),
         region: Map.get(properties, "state"),
-        description: Map.get(properties, "name") || streetAddress(properties),
+        description: Map.get(properties, "name") || street_address(properties),
         floor: Map.get(properties, "floor"),
         geom: Map.get(geometry, "coordinates") |> Provider.coordinates(),
         postal_code: Map.get(properties, "postcode"),
-        street: properties |> streetAddress()
+        street: properties |> street_address()
       }
     end)
   end
 
-  defp streetAddress(properties) do
+  defp street_address(properties) do
     if Map.has_key?(properties, "housenumber") do
       Map.get(properties, "housenumber") <> " " <> Map.get(properties, "street")
     else