Refactor Core things, including Ecto handling, ActivityPub & Transmogrifier modules

* Data doesn't need anymore to be converted to ActivityStream format to
be saved (this was taken from Pleroma and not at all a good idea here)
* Everything saved when creating an event is inserted into PostgreSQL in
a single transaction

lib/service/activity_pub/converter/comment.ex

@@ -11,6 +11,7 @@ defmodule Mobilizon.Service.ActivityPub.Converter.Comment do
   alias Mobilizon.Events.Event
   alias Mobilizon.Service.ActivityPub
   alias Mobilizon.Service.ActivityPub.{Converter, Convertible}
+  alias Mobilizon.Service.ActivityPub.Converter.Utils, as: ConverterUtils
 
   require Logger
 
@@ -26,57 +27,67 @@ defmodule Mobilizon.Service.ActivityPub.Converter.Comment do
   Converts an AP object data to our internal data structure.
   """
   @impl Converter
-  @spec as_to_model_data(map) :: map
+  @spec as_to_model_data(map) :: {:ok, map} | {:error, any()}
   def as_to_model_data(object) do
-    {:ok, %Actor{id: actor_id}} = ActivityPub.get_or_fetch_by_url(object["actor"])
-
-    Logger.debug("Inserting full comment")
+    Logger.debug("We're converting raw ActivityStream data to a comment entity")
     Logger.debug(inspect(object))
 
-    data = %{
-      "text" => object["content"],
-      "url" => object["id"],
-      "actor_id" => actor_id,
-      "in_reply_to_comment_id" => nil,
-      "event_id" => nil,
-      "uuid" => object["uuid"]
-    }
+    with {:ok, %Actor{id: actor_id}} <- ActivityPub.get_or_fetch_actor_by_url(object["actor"]),
+         {:tags, tags} <- {:tags, ConverterUtils.fetch_tags(object["tag"])},
+         {:mentions, mentions} <- {:mentions, ConverterUtils.fetch_mentions(object["tag"])} do
+      Logger.debug("Inserting full comment")
+      Logger.debug(inspect(object))
 
-    # We fetch the parent object
-    Logger.debug("We're fetching the parent object")
+      data = %{
+        text: object["content"],
+        url: object["id"],
+        actor_id: actor_id,
+        in_reply_to_comment_id: nil,
+        event_id: nil,
+        uuid: object["uuid"],
+        tags: tags,
+        mentions: mentions
+      }
 
-    data =
-      if Map.has_key?(object, "inReplyTo") && object["inReplyTo"] != nil &&
-           object["inReplyTo"] != "" do
-        Logger.debug(fn -> "Object has inReplyTo #{object["inReplyTo"]}" end)
+      # We fetch the parent object
+      Logger.debug("We're fetching the parent object")
 
-        case ActivityPub.fetch_object_from_url(object["inReplyTo"]) do
-          # Reply to an event (Event)
-          {:ok, %Event{id: id}} ->
-            Logger.debug("Parent object is an event")
-            data |> Map.put("event_id", id)
+      data =
+        if Map.has_key?(object, "inReplyTo") && object["inReplyTo"] != nil &&
+             object["inReplyTo"] != "" do
+          Logger.debug(fn -> "Object has inReplyTo #{object["inReplyTo"]}" end)
 
-          # Reply to a comment (Comment)
-          {:ok, %CommentModel{id: id} = comment} ->
-            Logger.debug("Parent object is another comment")
+          case ActivityPub.fetch_object_from_url(object["inReplyTo"]) do
+            # Reply to an event (Event)
+            {:ok, %Event{id: id}} ->
+              Logger.debug("Parent object is an event")
+              data |> Map.put(:event_id, id)
 
-            data
-            |> Map.put("in_reply_to_comment_id", id)
-            |> Map.put("origin_comment_id", comment |> CommentModel.get_thread_id())
+            # Reply to a comment (Comment)
+            {:ok, %CommentModel{id: id} = comment} ->
+              Logger.debug("Parent object is another comment")
 
-          # Anything else is kind of a MP
-          {:error, parent} ->
-            Logger.debug("Parent object is something we don't handle")
-            Logger.debug(inspect(parent))
-            data
+              data
+              |> Map.put(:in_reply_to_comment_id, id)
+              |> Map.put(:origin_comment_id, comment |> CommentModel.get_thread_id())
+
+            # Anything else is kind of a MP
+            {:error, parent} ->
+              Logger.debug("Parent object is something we don't handle")
+              Logger.debug(inspect(parent))
+              data
+          end
+        else
+          Logger.debug("No parent object for this comment")
+
+          data
         end
-      else
-        Logger.debug("No parent object for this comment")
 
-        data
-      end
-
-    data
+      {:ok, data}
+    else
+      err ->
+        {:error, err}
+    end
   end
 
   @doc """
@@ -85,14 +96,22 @@ defmodule Mobilizon.Service.ActivityPub.Converter.Comment do
   @impl Converter
   @spec model_to_as(CommentModel.t()) :: map
   def model_to_as(%CommentModel{} = comment) do
+    to =
+      if comment.visibility == :public,
+        do: ["https://www.w3.org/ns/activitystreams#Public"],
+        else: [comment.actor.followers_url]
+
     object = %{
       "type" => "Note",
-      "to" => ["https://www.w3.org/ns/activitystreams#Public"],
+      "to" => to,
+      "cc" => [],
       "content" => comment.text,
       "actor" => comment.actor.url,
       "attributedTo" => comment.actor.url,
       "uuid" => comment.uuid,
-      "id" => comment.url
+      "id" => comment.url,
+      "tag" =>
+        ConverterUtils.build_mentions(comment.mentions) ++ ConverterUtils.build_tags(comment.tags)
     }
 
     if comment.in_reply_to_comment do