refactor(backend): change naming of function names to avoid the is_ prefix

Following Credo.Check.Readability.PredicateFunctionNames check

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/mobilizon/actors/actor.ex

@@ -209,8 +209,8 @@ defmodule Mobilizon.Actors.Actor do
   @doc """
   Checks whether actor visibility is public.
   """
-  @spec is_public_visibility?(t) :: boolean
-  def is_public_visibility?(%__MODULE__{visibility: visibility}) do
+  @spec public_visibility?(t) :: boolean
+  def public_visibility?(%__MODULE__{visibility: visibility}) do
     visibility in [:public, :unlisted]
   end
 

lib/mobilizon/actors/actors.ex

@@ -710,8 +710,8 @@ defmodule Mobilizon.Actors do
   @doc """
   Returns whether the `actor_id` is a confirmed member for the group `parent_id`
   """
-  @spec is_member?(integer | String.t(), integer | String.t()) :: boolean()
-  def is_member?(actor_id, parent_id) do
+  @spec member?(integer | String.t(), integer | String.t()) :: boolean()
+  def member?(actor_id, parent_id) do
     match?(
       {:ok, %Member{}},
       get_member(actor_id, parent_id, @member_roles)
@@ -721,8 +721,8 @@ defmodule Mobilizon.Actors do
   @doc """
   Returns whether the `actor_id` is a moderator for the group `parent_id`
   """
-  @spec is_moderator?(integer | String.t(), integer | String.t()) :: boolean()
-  def is_moderator?(actor_id, parent_id) do
+  @spec moderator?(integer | String.t(), integer | String.t()) :: boolean()
+  def moderator?(actor_id, parent_id) do
     match?(
       {:ok, %Member{}},
       get_member(actor_id, parent_id, @moderator_roles)
@@ -732,8 +732,8 @@ defmodule Mobilizon.Actors do
   @doc """
   Returns whether the `actor_id` is an administrator for the group `parent_id`
   """
-  @spec is_administrator?(integer | String.t(), integer | String.t()) :: boolean()
-  def is_administrator?(actor_id, parent_id) do
+  @spec administrator?(integer | String.t(), integer | String.t()) :: boolean()
+  def administrator?(actor_id, parent_id) do
     match?(
       {:ok, %Member{}},
       get_member(actor_id, parent_id, @administrator_roles)
@@ -922,8 +922,8 @@ defmodule Mobilizon.Actors do
   @doc """
   Returns whether the member is the last administrator for a group
   """
-  @spec is_only_administrator?(integer | String.t(), integer | String.t()) :: boolean()
-  def is_only_administrator?(member_id, group_id) do
+  @spec only_administrator?(integer | String.t(), integer | String.t()) :: boolean()
+  def only_administrator?(member_id, group_id) do
     Member
     |> where(
       [m],

lib/mobilizon/actors/member.ex

@@ -55,9 +55,10 @@ defmodule Mobilizon.Actors.Member do
   @doc """
   Checks whether the member is an administrator (admin or creator) of the group.
   """
-  def is_administrator(%__MODULE__{role: :administrator}), do: true
-  def is_administrator(%__MODULE__{role: :creator}), do: true
-  def is_administrator(%__MODULE__{}), do: false
+  @spec administrator?(t()) :: boolean()
+  def administrator?(%__MODULE__{role: :administrator}), do: true
+  def administrator?(%__MODULE__{role: :creator}), do: true
+  def administrator?(%__MODULE__{}), do: false
 
   @doc false
   @spec changeset(t | Ecto.Schema.t(), map) :: Ecto.Changeset.t()