refactor(backend): change naming of function names to avoid the is_ prefix

Following Credo.Check.Readability.PredicateFunctionNames check

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

lib/web/controllers/page_controller.ex

@@ -173,26 +173,26 @@ defmodule Mobilizon.Web.PageController do
     end
   end
 
-  @spec is_visible?(map) :: boolean()
-  defp is_visible?(%{visibility: v}), do: v in [:public, :unlisted]
-  defp is_visible?(%Tombstone{}), do: true
-  defp is_visible?(_), do: true
+  @spec visible?(map) :: boolean()
+  defp visible?(%{visibility: v}), do: v in [:public, :unlisted]
+  defp visible?(%Tombstone{}), do: true
+  defp visible?(_), do: true
 
   @spec ok_status?(cache_status) :: boolean()
   defp ok_status?(status), do: status in [:ok, :commit]
 
   @typep cache_status :: :ok | :commit | :ignore
 
-  @spec ok_status_and_is_visible?(Plug.Conn.t(), cache_status, map()) :: boolean()
-  defp ok_status_and_is_visible?(_conn, status, o),
-    do: ok_status?(status) and is_visible?(o)
+  @spec ok_status_and_visible?(Plug.Conn.t(), cache_status, map()) :: boolean()
+  defp ok_status_and_visible?(_conn, status, o),
+    do: ok_status?(status) and visible?(o)
 
   defp checks?(conn, status, o) do
     cond do
-      ok_status_and_is_visible?(conn, status, o) ->
-        if is_local?(o) == :remote && get_format(conn) == "activity-json", do: :remote, else: true
+      ok_status_and_visible?(conn, status, o) ->
+        if local?(o) == :remote && get_format(conn) == "activity-json", do: :remote, else: true
 
-      is_person?(o) && get_format(conn) == "activity-json" ->
+      person?(o) && get_format(conn) == "activity-json" ->
         true
 
       true ->
@@ -200,9 +200,9 @@ defmodule Mobilizon.Web.PageController do
     end
   end
 
-  @spec is_local?(map()) :: boolean | :remote
-  defp is_local?(%{local: local}), do: if(local, do: true, else: :remote)
-  defp is_local?(_), do: false
+  @spec local?(map()) :: boolean | :remote
+  defp local?(%{local: local}), do: if(local, do: true, else: :remote)
+  defp local?(_), do: false
 
   @spec maybe_add_noindex_header(Plug.Conn.t(), map()) :: Plug.Conn.t()
   defp maybe_add_noindex_header(conn, %{visibility: visibility})
@@ -212,9 +212,9 @@ defmodule Mobilizon.Web.PageController do
 
   defp maybe_add_noindex_header(conn, _), do: conn
 
-  @spec is_person?(Actor.t()) :: boolean()
-  defp is_person?(%Actor{type: :Person}), do: true
-  defp is_person?(_), do: false
+  @spec person?(Actor.t()) :: boolean()
+  defp person?(%Actor{type: :Person}), do: true
+  defp person?(_), do: false
 
   defp maybe_add_content_type_header(conn) do
     case get_format(conn) do

lib/web/templates/email/date/event_tz_date_range.html.heex

@@ -6,7 +6,7 @@
       timezone: @timezone,
       locale: @locale
     ) %>
-  <% is_same_day?(@start_date, @end_date) -> %>
+  <% same_day?(@start_date, @end_date) -> %>
     <strong>
       <%= gettext("On %{date} from %{start_time} to %{end_time}",
         date: datetime_to_date_string(@start_date, @locale),

lib/web/templates/email/date/event_tz_date_range.text.eex

@@ -1 +1 @@
-<%= cond do %><% @end_date == nil -> %><%= render("date/event_tz_date.text", date: @start_date, event: @event, timezone: @timezone, locale: @locale) %><% is_same_day?(@start_date, @end_date) -> %><%= gettext "On %{date} from %{start_time} to %{end_time}", date: datetime_to_date_string(@start_date, @locale), start_time: datetime_to_time_string(@start_date, @locale), end_time: datetime_to_time_string(@end_date, @locale) %><%= if @event.options.timezone != @timezone do %> <%= gettext "🌐 %{timezone} %{offset}", timezone: @event.options.timezone, offset: Cldr.DateTime.Formatter.zone_gmt(@start_date) %><% end %><% true -> %><%= gettext "From the %{start} to the %{end}", start: datetime_to_string(@start_date, @locale, :short), end: datetime_to_string(@end_date, @locale, :short) %><%= if @event.options.timezone != @timezone do %> <%= gettext "🌐 %{timezone} %{offset}", timezone: @event.options.timezone, offset: Cldr.DateTime.Formatter.zone_gmt(@start_date) %><% end %><% end %>
+<%= cond do %><% @end_date == nil -> %><%= render("date/event_tz_date.text", date: @start_date, event: @event, timezone: @timezone, locale: @locale) %><% same_day?(@start_date, @end_date) -> %><%= gettext "On %{date} from %{start_time} to %{end_time}", date: datetime_to_date_string(@start_date, @locale), start_time: datetime_to_time_string(@start_date, @locale), end_time: datetime_to_time_string(@end_date, @locale) %><%= if @event.options.timezone != @timezone do %> <%= gettext "🌐 %{timezone} %{offset}", timezone: @event.options.timezone, offset: Cldr.DateTime.Formatter.zone_gmt(@start_date) %><% end %><% true -> %><%= gettext "From the %{start} to the %{end}", start: datetime_to_string(@start_date, @locale, :short), end: datetime_to_string(@end_date, @locale, :short) %><%= if @event.options.timezone != @timezone do %> <%= gettext "🌐 %{timezone} %{offset}", timezone: @event.options.timezone, offset: Cldr.DateTime.Formatter.zone_gmt(@start_date) %><% end %><% end %>

lib/web/templates/page/index.html.heex

@@ -15,7 +15,7 @@
         document.documentElement.classList.remove('dark')
       }
     </script>
-    <%= if is_root(assigns) do %>
+    <%= if root?(assigns) do %>
       <link rel="preload" href="/img/shape-1.svg" as="image" />
       <link rel="preload" href="/img/shape-2.svg" as="image" />
       <link rel="preload" href="/img/shape-3.svg" as="image" />

lib/web/views/email_view.ex

@@ -25,7 +25,7 @@ defmodule Mobilizon.Web.EmailView do
   defdelegate datetime_tz_convert(datetime, timezone), to: DateTimeRenderer
   defdelegate datetime_relative(datetime, locale \\ "en"), to: DateTimeRenderer
   defdelegate render_address(address), to: Address
-  defdelegate is_same_day?(one, two), to: DateTimeRenderer
+  defdelegate same_day?(one, two), to: DateTimeRenderer
   defdelegate display_name(actor), to: Actor
   defdelegate preferred_username_and_domain(actor), to: Actor
 

lib/web/views/page_view.ex

@@ -87,8 +87,8 @@ defmodule Mobilizon.Web.PageView do
     assigns |> Map.get(:locale, "en") |> get_language_direction()
   end
 
-  @spec is_root(map()) :: boolean()
-  def is_root(assigns) do
+  @spec root?(map()) :: boolean()
+  def root?(assigns) do
     assigns |> Map.get(:conn, %{request_path: "/"}) |> Map.get(:request_path, "/") == "/"
   end
 end